Skip to content

Updates the Terraform auto-plan workflow #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

mike-schenk
Copy link
Contributor

@mike-schenk mike-schenk commented Apr 1, 2024

  • adds -input=false to the terraform commands to avoid silent stalls in actions runs

- adds -input=false to the terraform commands to avoid silent stalls in actions runs
- updates action versions to fix node version deprecation warnings
@mike-schenk mike-schenk requested a review from a team as a code owner April 1, 2024 21:51
izep
izep previously approved these changes Apr 2, 2024
Copy link
Contributor

@izep izep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about that parameter...

@JosephDSchwartz JosephDSchwartz merged commit 6e73eb1 into main Apr 2, 2024
@JosephDSchwartz JosephDSchwartz deleted the tf-auto-plan-update branch April 2, 2024 13:22
@danielle-casella-adams
Copy link
Contributor

I didn't know about that parameter...

Same.

-input=true Ask for input if necessary. If false, will error if input was required.

I love this addition @mike-schenk!

@mike-schenk
Copy link
Contributor Author

I didn't know about that parameter...

Same.

-input=true Ask for input if necessary. If false, will error if input was required.

I love this addition @mike-schenk!

The reason I added it here is because I had a situation where a root module required a variable that wasn't provided, so Terraform was asking for the input... but in GitHub actions, that simply appears as a stalled step that eventually just fails with a timeout and with nothing in the logs for that step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants