SRE-208 - Updating workflow to output NEXT_RELEASE_VERSION. #283
Conversation
… to update package.json in npm builds.
There was a problem hiding this comment.
I don't think we should be committing package.json version numbers to the repo since we determine version numbers during our builds. My reasons are basically the same as what's documented by semantic-release here.
start-project is an example where the package version is not committed to source control: https://github.com/im-practices/start-project/blob/main/src/start-project/package.json
If there's another reason we need these outputs, I'll listen.
But regardless, I don't think it's worth running git-version-lite twice every time this reusable workflow is used when a very small subset of usages need the extra output.
As an alternative, we could expand git-version-lite itself to output the additional values directly.
|
Ok I will update the action to output both versions in git-version lite. |
|
I updated git-version-lite to output the bare versions. im-open/git-version-lite#49 please review. Once merged I will update this workflow. |
…XT_RELEASE_VERSION
|
@mike-schenk please review pull request. I have updated code per your request in your comments |
jsclifford
changed the title
NEXT_RELEASE_VERSIONandNEXT_RELEASE_VERSION_NO_PREFIX.