Skip to content

QAP 505 : Adding TestNG java schedule and manual workflow #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 26 commits into from
Closed

QAP 505 : Adding TestNG java schedule and manual workflow #289

wants to merge 26 commits into from

Conversation

ja3yntwillis
Copy link

No description provided.

Jayanta Dutta and others added 16 commits November 8, 2024 22:53
Initial commit to add App Insight healthcheck for Java based solutions
2a89b64
modified the filename
ecc46de
Merge branch 'main' of https://github.com/im-practices/.github into Q…
074367b 
…AP-505-Adding-Java-UI-Healthcheck-workflows
Updated Im-test-testng-java-schedule to save reports
d117697
made Run TestNG Tests
f1c997b 
added Authenticate with GitHub Packages
added testng tests
8d9ed9c
adding maven profile
09f4b09
Added Shell script information
fa6f322
Modified the Env paths
a6672d6
@ja3yntwillis
Update im-test-testng-schedule.yml
836acba
Modifying the template name for testng java properties
45c39b2
Steps for shell added
a201ef6
Added env var of App insight
5f4f904
Merge branch 'main' of https://github.com/im-practices/.github into Q…
bc99519 
…AP-505-Adding-Java-UI-Healthcheck-workflows
Adding Manual Workflow templates
93634dc
Clean up made in Manual Yaml
8083e83
@ja3yntwillis ja3yntwillis self-assigned this Nov 13, 2024
@ja3yntwillis ja3yntwillis requested a review from a team as a code owner November 13, 2024 15:46
@ja3yntwillis ja3yntwillis removed their assignment Nov 13, 2024
jsclifford
jsclifford requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@jsclifford jsclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to maven-cache step and you need to skip steps when the cache is hit.

ja3yntwillis and others added 6 commits November 14, 2024 16:44
@ja3yntwillis @jsclifford
Addition of suggestions
b90534c 
Co-authored-by: Josh Clifford <37558619+jsclifford@users.noreply.github.com>
@ja3yntwillis @jsclifford
added maven-cache
9b45559 
Co-authored-by: Josh Clifford <37558619+jsclifford@users.noreply.github.com>
fixing syntax n spaces
505a284
modifed manual gflow to recieve hits of cache
f76a635
modified maven dependency downloading step
7941f46
rename needs
31ee9dc
jsclifford
jsclifford reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@jsclifford jsclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but some minor suggestions.

ja3yntwillis and others added 2 commits November 14, 2024 22:20
@ja3yntwillis @jsclifford
modify job name for best practices
beb4174 
Co-authored-by: Josh Clifford <37558619+jsclifford@users.noreply.github.com>
@ja3yntwillis @jsclifford
modify job name for best practices
73dd0bf 
Co-authored-by: Josh Clifford <37558619+jsclifford@users.noreply.github.com>
@mike-schenk
Copy link
Contributor

mike-schenk commented Nov 14, 2024 •
edited
Loading

I don't think we should take on the burden of maintaining and troubleshooting Java environments on our runners when the same needs can be met with other environments. I.e. Selenium tests can be authored in TypeScript, JavaScript or C# which are all standard or allowed languages in our Tech Stack.

I vote to close the PR.

@ja3yntwillis
Copy link
Author

@mike-schenk

this workflow is added for the IM Customer Engagement (PEGA) team as they are currently using java based automation framework, this workflow should only be used if java is required by external vendor testing.

cc @jcfrperu @Oyun1 @jsclifford @jacobjithin

@mike-schenk
Copy link
Contributor

@mike-schenk

this workflow is added for the IM Customer Engagement (PEGA) team as they are currently using java based automation framework, this workflow should only be used if java is required by external vendor testing.

cc @jcfrperu @Oyun1 @jsclifford @jacobjithin

Since no other teams should use this, it shouldn't be in our shared templates. The Pega team can keep their copy in their own repository though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsclifford jsclifford jsclifford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ja3yntwillis @mike-schenk @jsclifford