Allow arbitrary number of samples as long as all have the same bit depth #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was pointed out in #214 , there doesn't seem to be any reason to return an unsupported error if samples isn't 1, 2, or 4.
This PR doesn't modify the behavior of
Decoder::colortype
. It will still return an error of typeUnsupportedError(InterpretationWithBits(..))
on such images. Matching on the error should expose the BitsPerSample and SamplesPerPixel values, though we should probably add a better way to access that information