Support ZSTD compression method for reading#256
Merged
fintelia merged 2 commits intoimage-rs:masterfrom Dec 20, 2024
Merged
Conversation
ZSTD is generally recognized as superior to LZW in size and speed, particularly for decompression. We use the self-assigned tag first defined by libtiff and also used by GDAL and others.
5444ff9 to
663c19c
Compare
Contributor
|
Thanks for this PR, zstd support is something I've wanted for a while! My main concern is actually around build time. On my machine, the I see two possible options:
|
Contributor
Author
|
Thanks for having a look! I looked into ruzstd but it seems to have a 1.5x-2x performance penalty over the reference implementation, which I felt would diminish the benefit of zstd too much. I added a feature flag now for the zstd support. |
Contributor
|
Thanks! If I have a chance, I might look into using ruzstd decoder by default and having the feature opt into the faster zstd bindings. Even the slower decoder may still significantly outperform LZW |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZSTD is generally recognized as superior to LZW in size and speed, particularly for decompression.
We use the self-assigned tag first defined by libtiff and also used by GDAL and others.