fix: chown shenanigans #410

hydazz · 2024-07-11T09:57:52Z

spawns chown in the background as a 'lazy' way of hopfully negating init stalls
also format scripts and update arm dockerfile

hydazz · 2024-07-11T10:02:39Z

also fixing the startup order, should go:
init-check-variables > init-config-immich > init-test-run > init-video-immich > services

hydazz · 2024-07-11T10:10:55Z

#394

ImageGeniusCI · 2024-07-11T10:12:34Z

I am a bot, here are the test results for this PR:
https://ci-tests.imagegenius.io/immich/v1.108.0-pkg-9ec4236b-dev-ed5b28502f05e5ced40020cbc0cb6c208cfe9993-pr-410/index.html
https://ci-tests.imagegenius.io/immich/v1.108.0-pkg-9ec4236b-dev-ed5b28502f05e5ced40020cbc0cb6c208cfe9993-pr-410/shellcheck-result.xml

Tag	Passed
amd64-v1.108.0-pkg-9ec4236b-dev-ed5b28502f05e5ced40020cbc0cb6c208cfe9993-pr-410	✅
arm64v8-v1.108.0-pkg-9ec4236b-dev-ed5b28502f05e5ced40020cbc0cb6c208cfe9993-pr-410	❌

ImageGeniusCI · 2024-07-11T10:30:09Z

I am a bot, here are the test results for this PR:
https://ci-tests.imagegenius.io/immich/v1.108.0-pkg-9ec4236b-dev-370e275ed55b8a230da5cf4f28eb12c2219af456-pr-410/index.html
https://ci-tests.imagegenius.io/immich/v1.108.0-pkg-9ec4236b-dev-370e275ed55b8a230da5cf4f28eb12c2219af456-pr-410/shellcheck-result.xml

Tag	Passed
amd64-v1.108.0-pkg-9ec4236b-dev-370e275ed55b8a230da5cf4f28eb12c2219af456-pr-410	✅
arm64v8-v1.108.0-pkg-9ec4236b-dev-370e275ed55b8a230da5cf4f28eb12c2219af456-pr-410	❌

martabal

Nice

hydazz · 2024-07-11T23:02:03Z

@martabal you think running chown in the background is the best way?

ImageGeniusCI · 2024-07-11T23:15:29Z

I am a bot, here are the test results for this PR:
https://ci-tests.imagegenius.io/immich/v1.108.0-pkg-9ec4236b-dev-898ebc8e245974f7ee394d291978e4965b7b5291-pr-410/index.html
https://ci-tests.imagegenius.io/immich/v1.108.0-pkg-9ec4236b-dev-898ebc8e245974f7ee394d291978e4965b7b5291-pr-410/shellcheck-result.xml

Tag	Passed
amd64-v1.108.0-pkg-9ec4236b-dev-898ebc8e245974f7ee394d291978e4965b7b5291-pr-410	✅
arm64v8-v1.108.0-pkg-9ec4236b-dev-898ebc8e245974f7ee394d291978e4965b7b5291-pr-410	❌

martabal · 2024-07-12T06:35:51Z

@martabal you think running chown in the background is the best way?

IMO, it is not. Someone who misconfigured his share won't realize this issue and this solution will impact people who don't have permission issues.

hydazz · 2024-07-12T07:33:08Z

How about this*

martabal · 2024-07-12T07:38:44Z

I think we'll have the same issue #273. We probably want to check if /photos have the correct permissions before changing them

hydazz · 2024-07-12T07:40:27Z

this is not a recursive chown, its just the photos folder, and subdirectories 1 depth

ImageGeniusCI · 2024-07-12T07:42:56Z

I am a bot, here are the test results for this PR:
https://ci-tests.imagegenius.io/immich/v1.108.0-pkg-9ec4236b-dev-054652848f38989e06532134e1f43b1e131a3401-pr-410/index.html
https://ci-tests.imagegenius.io/immich/v1.108.0-pkg-9ec4236b-dev-054652848f38989e06532134e1f43b1e131a3401-pr-410/shellcheck-result.xml

Tag	Passed
amd64-v1.108.0-pkg-9ec4236b-dev-054652848f38989e06532134e1f43b1e131a3401-pr-410	✅
arm64v8-v1.108.0-pkg-9ec4236b-dev-054652848f38989e06532134e1f43b1e131a3401-pr-410	❌

martabal · 2024-07-12T08:07:56Z

this is not a recursive chown, its just the photos folder, and subdirectories 1 depth

Will this work for files not owned by the abc user (for exemple files in a nfs mounted by root but with Immich started with a different user)?

hydazz · 2024-07-12T08:15:44Z

depends on how the nfs permissions are setup, the init scripts are ran as root, so if root has permission to modify the nfs files, then yes, its not being done by abc

cd Immich/
bash: cd: Immich/: Permission denied

whoami
root

cd Immich/

pwd
/mnt/nfs/Picard/Media/Immich

whoami
sandy

long story short, the NFS ACL need to match the UID of the local user set in the PUID

chown is not the way to edit/fix permissions on NFS shares, but we cant check if the mount is nfs soo...

root/etc/s6-overlay/s6-rc.d/svc-microservices/run

Co-authored-by: martin <74269598+martabal@users.noreply.github.com>

ImageGeniusCI · 2024-07-13T02:08:24Z

I am a bot, here are the test results for this PR:
https://ci-tests.imagegenius.io/immich/v1.108.0-pkg-9ec4236b-dev-80550b428b5d3ae3a50db47d713ed818c267d9e1-pr-410/index.html
https://ci-tests.imagegenius.io/immich/v1.108.0-pkg-9ec4236b-dev-80550b428b5d3ae3a50db47d713ed818c267d9e1-pr-410/shellcheck-result.xml

Tag	Passed
amd64-v1.108.0-pkg-9ec4236b-dev-80550b428b5d3ae3a50db47d713ed818c267d9e1-pr-410	✅
arm64v8-v1.108.0-pkg-9ec4236b-dev-80550b428b5d3ae3a50db47d713ed818c267d9e1-pr-410	❌

ImageGeniusCI · 2024-07-13T03:01:06Z

I am a bot, here are the test results for this PR:
https://ci-tests.imagegenius.io/immich/v1.108.0-pkg-9ec4236b-dev-9911beacdb02f859b497ea0df493257ed6b0ed2c-pr-410/index.html
https://ci-tests.imagegenius.io/immich/v1.108.0-pkg-9ec4236b-dev-9911beacdb02f859b497ea0df493257ed6b0ed2c-pr-410/shellcheck-result.xml

Tag	Passed
amd64-v1.108.0-pkg-9ec4236b-dev-9911beacdb02f859b497ea0df493257ed6b0ed2c-pr-410	✅
arm64v8-v1.108.0-pkg-9ec4236b-dev-9911beacdb02f859b497ea0df493257ed6b0ed2c-pr-410	❌

martabal

It still does not work ./run: line 7: 8: command not found

hydazz · 2024-07-13T09:44:50Z

It still does not work ./run: line 7: 8: command not found

my bad

hydazz · 2024-07-13T09:45:34Z

any other changes or good to merge?

ImageGeniusCI · 2024-07-13T09:53:43Z

I am a bot, here are the test results for this PR:
https://ci-tests.imagegenius.io/immich/v1.108.0-pkg-9ec4236b-dev-80550b428b5d3ae3a50db47d713ed818c267d9e1-pr-410/index.html
https://ci-tests.imagegenius.io/immich/v1.108.0-pkg-9ec4236b-dev-80550b428b5d3ae3a50db47d713ed818c267d9e1-pr-410/shellcheck-result.xml

Tag	Passed
amd64-v1.108.0-pkg-9ec4236b-dev-80550b428b5d3ae3a50db47d713ed818c267d9e1-pr-410	✅
arm64v8-v1.108.0-pkg-9ec4236b-dev-80550b428b5d3ae3a50db47d713ed818c267d9e1-pr-410	❌

martabal · 2024-07-13T10:04:52Z

Another issue caused during the first install: /usr/bin/find: ‘/photos/*’: No such file or directory

martabal · 2024-07-14T17:46:17Z

root/etc/s6-overlay/s6-rc.d/init-config-immich/run

 find /app/immich -path "*/node_modules" -prune -o -exec chown abc:abc {} +
 lsiown -R abc:abc \
    /config
+[[ "${APPLY_PERMISSIONS}" == "true" ]] && lsiown -R abc:abc "${IMMICH_MEDIA_LOCATION}"


I'm fine with it but maybe we should have it for /config too ?

/config should always be mounted locally, and not our problem if mounted any other way IMO

hydazz added 2 commits July 11, 2024 19:55

cleanup

abdcdc1

fix init start order

ed5b285

more cleanups

370e275

hydazz requested a review from martabal July 11, 2024 13:04

martabal approved these changes Jul 11, 2024

View reviewed changes

Update run

898ebc8

hydazz added 2 commits July 12, 2024 17:31

dont recursive chown

462feae

whoops

0546528

martabal approved these changes Jul 12, 2024

View reviewed changes

martabal requested changes Jul 12, 2024

View reviewed changes

root/etc/s6-overlay/s6-rc.d/svc-microservices/run Outdated Show resolved Hide resolved

hydazz mentioned this pull request Jul 13, 2024

unRAID - After last few updates (:cuda), Container takes a long time to start #415

Closed

Update root/etc/s6-overlay/s6-rc.d/svc-microservices/run

80550b4

Co-authored-by: martin <74269598+martabal@users.noreply.github.com>

hydazz requested a review from martabal July 13, 2024 06:35

martabal requested changes Jul 13, 2024

View reviewed changes

hydazz force-pushed the main branch from 9911bea to 80550b4 Compare July 13, 2024 09:43

commit

4164932

hydazz requested a review from martabal July 14, 2024 03:14

martabal approved these changes Jul 14, 2024

View reviewed changes

hydazz added 2 commits July 16, 2024 22:13

blank commit

7c3febb

fix exit 1

f04d03c

hydazz merged commit 7e45f0e into imagegenius:main Jul 16, 2024
1 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: chown shenanigans #410

fix: chown shenanigans #410

hydazz commented Jul 11, 2024

hydazz commented Jul 11, 2024

hydazz commented Jul 11, 2024

ImageGeniusCI commented Jul 11, 2024

ImageGeniusCI commented Jul 11, 2024

martabal left a comment

hydazz commented Jul 11, 2024

ImageGeniusCI commented Jul 11, 2024

martabal commented Jul 12, 2024

hydazz commented Jul 12, 2024

martabal commented Jul 12, 2024

hydazz commented Jul 12, 2024

ImageGeniusCI commented Jul 12, 2024

martabal commented Jul 12, 2024

hydazz commented Jul 12, 2024

ImageGeniusCI commented Jul 13, 2024

ImageGeniusCI commented Jul 13, 2024

martabal left a comment

hydazz commented Jul 13, 2024

hydazz commented Jul 13, 2024

ImageGeniusCI commented Jul 13, 2024

martabal commented Jul 13, 2024

martabal Jul 14, 2024

hydazz Jul 16, 2024

fix: chown shenanigans #410

fix: chown shenanigans #410

Conversation

hydazz commented Jul 11, 2024

hydazz commented Jul 11, 2024

hydazz commented Jul 11, 2024

ImageGeniusCI commented Jul 11, 2024

ImageGeniusCI commented Jul 11, 2024

martabal left a comment

Choose a reason for hiding this comment

hydazz commented Jul 11, 2024

ImageGeniusCI commented Jul 11, 2024

martabal commented Jul 12, 2024

hydazz commented Jul 12, 2024

martabal commented Jul 12, 2024

hydazz commented Jul 12, 2024

ImageGeniusCI commented Jul 12, 2024

martabal commented Jul 12, 2024

hydazz commented Jul 12, 2024

ImageGeniusCI commented Jul 13, 2024

ImageGeniusCI commented Jul 13, 2024

martabal left a comment

Choose a reason for hiding this comment

hydazz commented Jul 13, 2024

hydazz commented Jul 13, 2024

ImageGeniusCI commented Jul 13, 2024

martabal commented Jul 13, 2024

martabal Jul 14, 2024

Choose a reason for hiding this comment

hydazz Jul 16, 2024

Choose a reason for hiding this comment