Do not use base64 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... because it will require an explicit dependency since Ruby 3.4.0.
|
Hi @mame. Could you fix failing Rubocop rule (looks like you need to change double -> single quotes)? I will gladly merge it afterwards. |
|
@imanel Thank you! I have force-pushed. |
|
Merged, thanks for your contribution! |
|
And released as part of 1.2.10 |
mame
added a commit
to mame/websocket-ruby
that referenced
this pull request
Jun 21, 2024
Follow up imanel#51
|
Sorry, I forgot to remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.4.0 will bundle base64 as a gem. This means
websocket.gemspecneed to explicitly depend on the gem bygem 'base64'.Currently, this gem only uses
Base64.encode64. So, how about useArray#packinstead of the base64 gem?If you prefer to add
gem 'base64'to gemspec, let me know. I will be happy to change this PR.