chore: make system_cpu[1]_active_percentage optional #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
format via `cargo fmt`
weriomat
force-pushed
the
cpu_active_percentage
branch
from
55f917d to
e2f2f5d
Compare
Author
|
I have reworked this PR and included some quick improvements as well as the original fix |
Author
|
@imatefx I would like to request a review from you :) |
Some refactor as all the values are the same. Fix where some values are not exported on some typesense instances. This should fix imatefx#7.
weriomat
force-pushed
the
cpu_active_percentage
branch
from
e2f2f5d to
f7063db
Compare
cyppe
added a commit
to cyppe/typesense-prometheus-exporter
that referenced
this pull request
Jan 13, 2026
…ements This PR consolidates and builds upon existing community contributions: Credits: - PR imatefx#11 by @berciktymansen - Makes CPU fields optional - PR imatefx#13 by @berciktymansen - Adds health endpoint and raft state metrics Additional improvements: - Dynamic CPU handling using serde flatten (supports any CPU count) - Swap memory metrics (system_memory_total_swap_bytes, system_memory_used_swap_bytes) - Cache hit ratio metric from stats endpoint - Removed verbose "No match found" log spam for non-collection endpoints All changes are backward compatible with older Typesense versions. Tested against Typesense v30.0.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, apparently my instance does not emit any
system_cpu*_active_percentage. This PR makessystem_cpu1_active_percentageandsystem_cpu_active_percentageoptional.