Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "unstable" css style for light mode #77

Merged
merged 2 commits into from
Sep 20, 2022
Merged

fix "unstable" css style for light mode #77

merged 2 commits into from
Sep 20, 2022

Conversation

cabanier
Copy link
Member

@cabanier cabanier commented Sep 20, 2022 •
edited by pr-preview bot
Loading

otherwise unstable sections are unreadable in light mode.

Preview | Diff

@cabanier cabanier requested a review from bialpio September 20, 2022 03:38
bialpio
bialpio reviewed Sep 20, 2022
View reviewed changes
index.bs Show resolved Hide resolved
bialpio
bialpio approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@bialpio bialpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a question (I think re-specifying background-image in light mode may not be needed?).

@cabanier cabanier merged commit d8ac12b into immersive-web:main Sep 20, 2022
github-actions bot added a commit that referenced this pull request Sep 20, 2022
@cabanier @github-actions
Merge pull request #77 from cabanier/main
e980e77 
SHA: d8ac12b
Reason: push, by @cabanier

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bialpio bialpio bialpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cabanier @bialpio