refactor(server): move database restores code into a service #25918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… name is not mangled fixes #25633 Signed-off-by: izzy <me@insrt.uk>
Signed-off-by: izzy <me@insrt.uk>
…ible chore: late fallback for username in parameter builder Signed-off-by: izzy <me@insrt.uk>
Signed-off-by: izzy <me@insrt.uk>
Signed-off-by: izzy <me@insrt.uk>
jrasm91
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the implementations in the database backup utility file into the (existing)
DatabaseBackupService. This service no longer extends fromBaseServiceso it can be used in both maintenance and non-maintenance workers.The DI for the service optionally pulls in the cron, job, and maintenance health repositories depending on what is available, hence allowing it to work in both contexts.
MaintenanceWorkerService<-DatabaseBackupService.How Has This Been Tested?
Existing tests have been moved from
maintenance-worker.service.spec.ts&backup.service.spec.tsintodatabase-backup.service.spec.ts.Additional tests have been written for:
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
No LLM use.