feat(mobile): use shared native client #25942
Open
+772
−501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix android
platform-side headers update comment consistent platform check tweak websocket handling support streaming
mertalev
force-pushed
the
feat/use-native-clients
branch
from
ec63816 to
03afe8f
Compare
This was referenced Feb 7, 2026
Contributor
|
With the changes in this branch, I am able to log into the immich app and view my timeline, but foreground uploads do not work. I have not tested background uploads. Foreground uploads error out with the following: Message: From: Shortly after that, I see: Message: I can repro the error if I log out and log back in. I don't see anything interesting in my immich server logs. (I'm connected to a immich server over HTTPS with a certificate signed by my own self-hosted certificate authority, although I cannot imagine how that's relevant here). |
Member
Author
|
Hmm, it might not be setting headers correctly on Android. I think I only tested upload on iOS. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves API requests from a Dart client to a shared native client that is instantiated at startup. This change improves performance and (mostly) consolidates configuration to a single place. Among other things, this should also improve the mTLS experience. The main remaining exceptions to this are asset downloading and background uploads, which don't use the same session as they're handled in dependencies. This can be addressed separately from this PR.
How Has This Been Tested?
Tested login, browsing, asset upload and websocket events on both platforms.