-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
feat(mobile): inline asset details #25952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c357f0b to
2f68c95
Compare
34db059 to
c230c9c
Compare
|
Hello, I just ran a quick test, and there are two points that need to be changed
|
c230c9c to
9d6f41a
Compare
|
One thing which might be nice - it currently hard stops when scrolling to the bottom, a bouncy / springy scroll would feel a bit better . |
|
Apple Photos fullscreens and hides the time etc. when the bottom sheet is opened. I think that's the nicest behavior |
|
I'm open to trying that. I probably won't be able to take a look until tomorrow evening though. |
I would prioritize making it look great for images. I'd like to keep it as is on
I don't think we need the bottomsheet move with the images, as long as the bottomsheet isn't dismissed and the data is updated, then I am fine with that 😄 |
|
The behaviour on main is a bit different, because the bottom sheet doesn't go behind the status bar and scrolls differently. We could meet in the middle and make the black/white bar transparent? Does that work for you? Or does Mert's suggestion of making it full screen sound better? |
9d6f41a to
5dd6d5f
Compare
|
I've updated the PR to hide the system UI when the asset details are showing. Let me know what you think. |
47f27e5 to
932e3a1
Compare
|
Per discussion in discord, hiding the system UI on Android makes the app very laggy. This doesn't seem to be the case on iOS, so we are going to hide the system UI on iOS, and use a semi-transparent black box behind the system bar on Android. |
329077b to
76704a2
Compare
The existing implementation for showing asset details uses a bottom sheet, and is not in sync with the preview or scroll intent. Other apps use inline details, which is much cleaner and feels better to use.
76704a2 to
f87581b
Compare


Description
The existing implementation for showing asset details uses a bottom sheet, and is not in sync with the preview or scroll intent. Other apps use inline details, which is much cleaner and feels better to use.
How Has This Been Tested?
Tested in an emulator.
Screenshots (if appropriate)
demo2.mp4
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
I did use Claude Code to bounce ideas off of, but most of the code is written by me, and any code written with the help of Claude has been reviewed.