fix: when removing asset (used as featured person asset), assign new … #26084
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…featured asset
Description
With the person, there is a featured asset shown. But after deleting that asset delivering the thumbnail, the same asset is still shown as thumbnail. This can be triggered by 2 path. Either by deleting the asset or by deleting the person from the asset. In both paths, the asset should not be part of the person, so definitely not be used as thumbnail.
So as solution, a randomly new asset is chosen and afterwards the thumbnail is generated in a job.
How Has This Been Tested?
steps to reproduce:
expected result:
The featured photo of the person is adapted
actual result:
The featured photo is changed => medium test provided
steps to reproduce:
expected result:
The featured photo of the person is adapted
actual result:
The featured photo is changed => medium test provided
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
To create testcode, but no original code of the LLM is left...