Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proc macro punctuation panic #1197

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fix proc macro punctuation panic #1197

merged 1 commit into from
Jan 29, 2025

Conversation

fw-immunant
Copy link
Contributor

Should fix #1142.

this should allow using newer versions of proc_macro2
@fw-immunant fw-immunant requested a review from kkysen January 27, 2025 18:19
Copy link
Contributor

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kornelski, does this fix the issue? You can test it by checking out this branch and then rm Cargo.lock and cargo +stable install --path c2rust (since cargo install --git doesn't allow --bin).

@fw-immunant
Copy link
Contributor Author

LGTM.

@kornelski, does this fix the issue? You can test it by checking out this branch and then rm Cargo.lock and cargo +stable install --path c2rust (since cargo install --git doesn't allow --bin).

This appears to fix the issue locally; a build with proc-macro2 v1.0.93 following the above instructions seems to correctly process the .c files I threw at it.

@fw-immunant fw-immunant merged commit 3b1ec86 into master Jan 29, 2025
9 checks passed
@fw-immunant fw-immunant deleted the fw/proc-macro-punct branch January 29, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thread 'main' panicked at 'unsupported proc macro punctuation character '(''
2 participants