Open
Conversation
sp-relative instructions do not enforce MTE we check this by seeing if the pointer operand is an AllocaInst; I'm not 100% sure this is sufficient but it seems so thus far
fw-immunant
force-pushed
the
fw/instrument-llvm-ir
branch
2 times, most recently
from
fb24602 to
242416c
Compare
fw-immunant
force-pushed
the
fw/instrument-llvm-ir
branch
from
242416c to
29239a7
Compare
fw-immunant
force-pushed
the
fw/instrument-llvm-ir
branch
from
dd900ef to
0e724f2
Compare
fw-immunant
force-pushed
the
fw/instrument-llvm-ir
branch
from
0201415 to
d8a86e2
Compare
fw-immunant
force-pushed
the
fw/instrument-llvm-ir
branch
from
dcbe96a to
b510037
Compare
fw-immunant
force-pushed
the
fw/instrument-llvm-ir
branch
from
6d75250 to
ee4b89a
Compare
fw-immunant
force-pushed
the
fw/instrument-llvm-ir
branch
from
ee4b89a to
07990b5
Compare
fw-immunant
force-pushed
the
fw/instrument-llvm-ir
branch
from
5d149fa to
bb1e362
Compare
ayrtonm
reviewed
Nov 22, 2024
| continue; | ||
| } | ||
|
|
||
| IRBuilder<> IRB(&*I); |
There was a problem hiding this comment.
Do we need to call IRB.SetInsertPoint? (at least before the CreateIntToPtr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.