Skip to content

Commit

Permalink
Fix secrets ref
Browse files Browse the repository at this point in the history
  • Loading branch information
sergerad committed Jan 6, 2025
1 parent 687e61b commit 385f3fa
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 22 deletions.
9 changes: 3 additions & 6 deletions .github/actions/push/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@ on:
required: false
type: string
default: ""
secrets:
github-token:
required: true

# this is used by github OIDC to assume the admin role later on
permissions: # see this: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
Expand All @@ -59,22 +56,22 @@ jobs:
with:
fetch-depth: 0
submodules: false
token: ${{ secrets.github-token }}
token: ${{ secrets.PLATFORM_SA_GITHUB_TOKEN }}
ref: ${{ inputs.git-release-tag }}

- name: Log in to GitHub Container Registry
uses: docker/login-action@v2
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.github-token }}
password: ${{ secrets.PLATFORM_SA_GITHUB_TOKEN }}

- name: Extract Docker metadata
id: meta
uses: docker/metadata-action@v4
with:
images: ghcr.io/${{ github.repository }}/s
github-token: ${{ secrets.github-token }}
github-token: ${{ secrets.PLATFORM_SA_GITHUB_TOKEN }}

- name: Set env vars
run: |
Expand Down
7 changes: 0 additions & 7 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,12 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0
submodules: false
token: ${{ secrets.github-token }}
ref: ${{ inputs.git-release-tag }}
- uses: ./.github/actions/push
with:
environment: dev
dockerfile: "Dockerfile"
go-mod-cache-path: "~/go/pkg/mod"
go-build-cache-path: "~/.cache/go-build"
secrets:
github-token: ${{ secrets.PLATFORM_SA_GITHUB_TOKEN }}

tests:
name: Tests
Expand Down
10 changes: 1 addition & 9 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,13 @@ jobs:
name: temporary
runs-on: ubuntu-20-04-4-cores
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0
submodules: false
token: ${{ secrets.github-token }}
ref: ${{ inputs.git-release-tag }}
- uses: actions/checkout@v3
- uses: ./.github/actions/push
with:
environment: dev
dockerfile: "Dockerfile"
go-mod-cache-path: "~/go/pkg/mod"
go-build-cache-path: "~/.cache/go-build"
secrets:
github-token: ${{ secrets.PLATFORM_SA_GITHUB_TOKEN }}

bootstrap:
name: Local E2E Tests
Expand Down

0 comments on commit 385f3fa

Please sign in to comment.