Conversation
lfportal
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses feedback from the external audit, documented here.
Note
Medium Risk
Changes affect core withdrawal authorization (who can set the vault root) and proof validation strictness; misconfiguration of the new
vault_root_provideraddress or unexpected proof formats could block withdrawals.Overview
Vault root setting is tightened and re-wired.
VaultWithdrawalProcessornow takes an immutableVAULT_ROOT_PROVIDERaddress in the constructor (wired from newvault_root_providerconfig + deploy script) andsetVaultRootno longer uses an AccessControl role; it instead enforcesmsg.sender == VAULT_ROOT_PROVIDERwith a dedicatedUnauthorizedVaultRootProvidererror.Proof validation is made stricter.
VaultEscapeProofVerifiernow only accepts proofs of exactly length 68 (single supported format) and the processor relies on the verifier for length checks; unit tests are updated to match the new revert reasons.Proxy/upgrade safety improvement.
StarkExchangeMigrationnow disables initializers in the implementation constructor, and tests are updated to deploy it behind anERC1967Proxyand assert initialization behavior accordingly.Written by Cursor Bugbot for commit 3587321. This will update automatically on new commits. Configure here.