Cleaned unit tests and removed assembly signature

imperugo · Jan 20, 2025 · 53734ec · 53734ec
1 parent d6f8458
commit 53734ec
Show file tree

Hide file tree

Showing 5 changed files with 60 additions and 156 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project>
-
     <!-- General information -->
     <PropertyGroup>
         <Authors>Ugo Lattanzi</Authors>
@@ -90,6 +89,12 @@
         <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
 
+    <ItemGroup>
+        <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
+            <_Parameter1>$(MSBuildProjectName).Tests</_Parameter1>
+        </AssemblyAttribute>
+    </ItemGroup>
+
     <ItemGroup>
         <AssemblyAttribute Include="System.Diagnostics.CodeAnalysis.SuppressMessage">
             <_Parameter1>Style</_Parameter1>

diff --git a/...tackExchange.Redis.Extensions.AspNetCore/StackExchange.Redis.Extensions.AspNetCore.csproj b/...tackExchange.Redis.Extensions.AspNetCore/StackExchange.Redis.Extensions.AspNetCore.csproj
@@ -8,12 +8,6 @@
     <Nullable>enable</Nullable>
   </PropertyGroup>
 
-  <!-- Assembly signing -->
-  <PropertyGroup>
-    <AssemblyOriginatorKeyFile>..\..\StackExchange.Redis.Extensions.Core.snk</AssemblyOriginatorKeyFile>
-    <SignAssembly>true</SignAssembly>
-  </PropertyGroup>
-
   <ItemGroup>
     <FrameworkReference Include="Microsoft.AspNetCore.App" />
     <ProjectReference Include="..\..\core\StackExchange.Redis.Extensions.Core\StackExchange.Redis.Extensions.Core.csproj" />

diff --git a/src/core/StackExchange.Redis.Extensions.Core/StackExchange.Redis.Extensions.Core.csproj b/src/core/StackExchange.Redis.Extensions.Core/StackExchange.Redis.Extensions.Core.csproj
@@ -2,8 +2,6 @@
 
   <!-- Assembly signing -->
   <PropertyGroup>
-    <AssemblyOriginatorKeyFile>..\..\StackExchange.Redis.Extensions.Core.snk</AssemblyOriginatorKeyFile>
-    <SignAssembly>true</SignAssembly>
     <Nullable>enable</Nullable>
   </PropertyGroup>
 

diff --git a/tests/StackExchange.Redis.Extensions.Core.Tests/CacheClientTestBase.Hash.cs b/tests/StackExchange.Redis.Extensions.Core.Tests/CacheClientTestBase.Hash.cs
@@ -4,6 +4,7 @@
 using System.Collections.Generic;
 using System.Threading.Tasks;
 
+using StackExchange.Redis.Extensions.Core.Helpers;
 using StackExchange.Redis.Extensions.Core.Tests.Helpers;
 
 using Xunit;
@@ -88,13 +89,13 @@ public async Task HashSetMultipleValues_HashGetMultipleValues_ShouldInsert_Async
         await Sut.GetDefaultDatabase().HashSetAsync(hashKey, map);
         await Task.Delay(1000);
 
+        var keys = map.Keys.ToFastArray(x => (RedisValue)x);
+
         // assert
-        var data = (await db
-            .HashGetAsync(hashKey, map.Keys.Select(x => (RedisValue)x).ToArray()))
-            .ToList()
-            .ConvertAll(x => serializer.Deserialize<TestClass<DateTime>>(x!));
+        var data = (await db.HashGetAsync(hashKey, keys))
+            .ToFastArray(x => serializer.Deserialize<TestClass<DateTime>>(x!));
 
-        Assert.Equal(map.Count, data.Count);
+        Assert.Equal(map.Count, data.Length);
 
         foreach (var val in data)
             Assert.True(map.ContainsValue(val!), $"result map doesn't contain value: {val}");
@@ -443,8 +444,8 @@ var values
 
         foreach (var key in values.Keys)
         {
-            Assert.True(resultEnum.ContainsKey(key!));
-            Assert.Equal(values[key], resultEnum[key!]);
+            Assert.True(resultEnum.ContainsKey(key));
+            Assert.Equal(values[key], resultEnum[key]);
         }
     }
 
@@ -466,12 +467,12 @@ var values
         // assert
         Assert.NotNull(result);
         var resultEnum = result.ToDictionary(x => x.Key, x => x.Value);
-        Assert.Equal(values.Keys.Count(x => x!.StartsWith('2')), resultEnum.Count);
+        Assert.Equal(values.Keys.Count(x => x.StartsWith('2')), resultEnum.Count);
 
-        foreach (var key in values.Keys.Where(x => x!.StartsWith('2')))
+        foreach (var key in values.Keys.Where(x => x.StartsWith('2')))
         {
-            Assert.True(resultEnum.ContainsKey(key!));
-            Assert.Equal(values[key], resultEnum[key!]);
+            Assert.True(resultEnum.ContainsKey(key));
+            Assert.Equal(values[key], resultEnum[key]);
         }
     }
 }