Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] - Update gradle version to be compatible with Java 17 and … #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

isidro-ruiz
Copy link

…fix for NullPointerException

ruizis added 2 commits November 3, 2022 11:24

Verified

This commit was signed with the committer’s verified signature.
…fix for NullPointerException
TestReporter.log("");
Assert.fail(anyException.getMessage());
return;
}

int statusCode = httpResponse.getStatusLine().getStatusCode();
boolean isStatusCodeValid = httpResponseValidator.isValidHttpCode(statusCode);
TestReporter.log((isStatusCodeValid? " " : " ") +"Request was: " + httpRequest.toString() + ", Response status code: " + statusCode + (isStatusCodeValid? " " : " (UNEXPECTED)"));
TestReporter.log((isStatusCodeValid? "ok " : "not ok ") +"Request was: " + httpRequest.toString() + ", Response status code: " + statusCode + (isStatusCodeValid? " " : " (UNEXPECTED)"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Do the visual marks create any issues? Their intention was only to help see whether there were issues visually.
I suggest having both the text and the visual marks.

@isidro-ruiz
Copy link
Author

isidro-ruiz commented Nov 4, 2022 via email

@thenorthernpole
Copy link
Contributor

Thanks!
Is there a visual character we can use which will work for both?

Thanks!

@isidro-ruiz
Copy link
Author

isidro-ruiz commented Nov 4, 2022 via email

@thenorthernpole
Copy link
Contributor

Thanks! Would appreciate it if you could incorporate such a character that is compatible with your WIndows machine, and I will approve.

Thanks!

@isidro-ruiz
Copy link
Author

isidro-ruiz commented Nov 5, 2022 via email

@thenorthernpole
Copy link
Contributor

Hey @isidro-ruiz , are you planning on making the changes?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants