-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INTERNAL] - Update gradle version to be compatible with Java 17 and … #11
base: master
Are you sure you want to change the base?
Conversation
…fix for NullPointerException
TestReporter.log(""); | ||
Assert.fail(anyException.getMessage()); | ||
return; | ||
} | ||
|
||
int statusCode = httpResponse.getStatusLine().getStatusCode(); | ||
boolean isStatusCodeValid = httpResponseValidator.isValidHttpCode(statusCode); | ||
TestReporter.log((isStatusCodeValid? "✅ " : "❌ ") +"Request was: " + httpRequest.toString() + ", Response status code: " + statusCode + (isStatusCodeValid? " " : " (UNEXPECTED)")); | ||
TestReporter.log((isStatusCodeValid? "ok " : "not ok ") +"Request was: " + httpRequest.toString() + ", Response status code: " + statusCode + (isStatusCodeValid? " " : " (UNEXPECTED)")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change. Do the visual marks create any issues? Their intention was only to help see whether there were issues visually.
I suggest having both the text and the visual marks.
Hi yes. In Windows these marks give exceptions as those ASCII chars are
not compatible and only work for Linux....
El vie, 4 nov 2022 23:14, Boris Serebro ***@***.***> escribió:
… ***@***.**** commented on this pull request.
------------------------------
In src/main/java/com/imperva/apiattacktool/tests/MainTest.java
<#11 (comment)>
:
> TestReporter.log("");
Assert.fail(anyException.getMessage());
return;
}
int statusCode = httpResponse.getStatusLine().getStatusCode();
boolean isStatusCodeValid = httpResponseValidator.isValidHttpCode(statusCode);
- TestReporter.log((isStatusCodeValid? "✅ " : "❌ ") +"Request was: " + httpRequest.toString() + ", Response status code: " + statusCode + (isStatusCodeValid? " " : " (UNEXPECTED)"));
+ TestReporter.log((isStatusCodeValid? "ok " : "not ok ") +"Request was: " + httpRequest.toString() + ", Response status code: " + statusCode + (isStatusCodeValid? " " : " (UNEXPECTED)"));
Thanks for the change. Do the visual marks create any issues? Their
intention was only to help see whether there were issues visually.
I suggest having both the text and the visual marks.
—
Reply to this email directly, view it on GitHub
<#11 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALYM4G5DS2ANVH4KFNODFNLWGWDDLANCNFSM6AAAAAARV7LUBE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Thanks! Thanks! |
No problema. I Guess you can use the Unicode one of this versión, ir should
work for both: https://en.wikipedia.org/wiki/Check_mark#Unicode
Other important changes un that pull request are the upgrade of gradle
version in order to support jdk17 and the check for an scenario coming with
empty values and trowing an excepcion
El vie, 4 nov 2022 23:51, Boris Serebro ***@***.***> escribió:
… Thanks!
Is there a visual character we can use which will work for both?
Thanks!
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALYM4GYCEJRAQBF5MFDUHGDWGWHPDANCNFSM6AAAAAARV7LUBE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Thanks! Would appreciate it if you could incorporate such a character that is compatible with your WIndows machine, and I will approve. Thanks! |
Ok thank u!
El sáb, 5 nov 2022 23:04, Boris Serebro ***@***.***> escribió:
… Thanks! Would appreciate it if you could incorporate such a character that
is compatible with your WIndows machine, and I will approve.
Thanks!
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALYM4GZGCBKR6VWAO4LBFGTWG3KVHANCNFSM6AAAAAARV7LUBE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Hey @isidro-ruiz , are you planning on making the changes? Thanks! |
…fix for NullPointerException