code updated for ci yaml (#613)

implerhq · Jun 25, 2024 · 42cc75e · 42cc75e
2 parents 59d60ba + c737385
commit 42cc75e
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 14 deletions.
diff --git a/.github/workflows/build-api.yml b/.github/workflows/build-api.yml
@@ -12,8 +12,8 @@ jobs:
     if: "!contains(github.event.head_commit.message, 'ci skip')"
     # The type of runner that the job will run on
     runs-on: ubuntu-latest
-    outputs:
-      build_status: ${{ steps.set_output.outputs.build_status }}
+    # outputs:
+    #   build_status: ${{ steps.set_output.outputs.build_status }}
     timeout-minutes: 80
     permissions:
       contents: read
@@ -58,7 +58,6 @@ jobs:
           GH_ACTOR: implerhq
           GH_PASSWORD: ${{ secrets.GH_PACKAGES }}
         run: |
-          [ -z "$GH_PASSWORD" ] && { echo "Error: GH_PASSWORD is not set"; exit 1; }
           echo $GH_PASSWORD | docker login ghcr.io -u $GH_ACTOR --password-stdin
           docker build -t ghcr.io/$REGISTERY_OWNER/$DOCKER_NAME:$IMAGE_TAG -f apps/api/Dockerfile .
           docker tag ghcr.io/$REGISTERY_OWNER/$DOCKER_NAME:$IMAGE_TAG ghcr.io/$REGISTERY_OWNER/$DOCKER_NAME:latest
@@ -72,7 +71,7 @@ jobs:
           docker push ghcr.io/$REGISTERY_OWNER/$DOCKER_NAME:$IMAGE_TAG
           echo "::set-output name=IMAGE::ghcr.io/$REGISTERY_OWNER/$DOCKER_NAME:$IMAGE_TAG"
 
-      - name: Set build status
-        if: success()
-        id: set_output
-        run: echo "::set-output name=build_status::success"
+      # - name: Set build status
+      #   if: success()
+      #   id: set_output
+      #   run: echo "::set-output name=build_status::success"
diff --git a/.github/workflows/build-embed.yml b/.github/workflows/build-embed.yml
@@ -11,8 +11,8 @@ jobs:
     if: "!contains(github.event.head_commit.message, 'ci skip')"
     # The type of runner that the job will run on
     runs-on: ubuntu-latest
-    outputs:
-      build_status: ${{ steps.set_output.outputs.build_status }}
+    # outputs:
+    #   build_status: ${{ steps.set_output.outputs.build_status }}
     timeout-minutes: 80
     # environment: Production
     permissions:
@@ -66,7 +66,7 @@ jobs:
           docker push ghcr.io/$REGISTERY_OWNER/$DOCKER_NAME:$IMAGE_TAG
           echo "::set-output name=IMAGE::ghcr.io/$REGISTERY_OWNER/$DOCKER_NAME:$IMAGE_TAG"
 
-      - name: Set build status
-        if: success()
-        id: set_output
-        run: echo "::set-output name=build_status::success"
+      # - name: Set build status
+      #   if: success()
+      #   id: set_output
+      #   run: echo "::set-output name=build_status::success"
diff --git a/.github/workflows/deploy-quality.yaml b/.github/workflows/deploy-quality.yaml
@@ -56,7 +56,10 @@ jobs:
       # - build_queuemanager
       # - build_web
       # - build_widget
-    if: needs.build_api.outputs.build_status == 'success' || needs.build_api.outputs.build_status == 'success'
+    # if: needs.build_api.outputs.build_status == 'success' || needs.build_api.outputs.build_status == 'success'
+    if: |
+      always() && 
+      (needs.build_api.result == 'success' || needs.build_embed.result == 'success')
     steps:
       - name: Set up SSH and Run Docker Compose Up
         uses: webfactory/ssh-agent@v0.5.3