feat: Updated google analytics tracking by manual track and proper …

…id (#459)
implerhq · Jan 12, 2024 · 4534b0b · 4534b0b
2 parents e0f253c + 54bcfb0
commit 4534b0b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/apps/web/design-system/button/Button.tsx b/apps/web/design-system/button/Button.tsx
@@ -1,14 +1,15 @@
+import { PropsWithChildren } from 'react';
 import useStyles from './Button.styles';
 import { Button as MantineButton, MantineSize } from '@mantine/core';
 
 export type ButtonColors = 'blue' | 'invariant' | 'red' | 'green';
 export type ButtonVariants = 'filled' | 'outline';
 
 interface ButtonProps {
+  id?: string;
   leftIcon?: any;
   rightIcon?: any;
   color?: ButtonColors;
-  children?: any;
   size?: MantineSize;
   component?: any;
   type?: 'button' | 'submit' | 'reset';
@@ -22,6 +23,7 @@ interface ButtonProps {
 
 export function Button({
   children,
+  id,
   leftIcon,
   rightIcon,
   href,
@@ -34,7 +36,7 @@ export function Button({
   size = 'sm',
   color = 'blue',
   variant = 'filled',
-}: ButtonProps) {
+}: PropsWithChildren<ButtonProps>) {
   const { classes } = useStyles({ variant, color, fullWidth });
 
   return (
@@ -50,6 +52,7 @@ export function Button({
       onClick={onClick}
       loading={loading}
       disabled={disabled}
+      id={id}
     >
       {children}
     </MantineButton>

diff --git a/apps/web/pages/auth/signin.tsx b/apps/web/pages/auth/signin.tsx
@@ -27,6 +27,7 @@ export default function SigninPage() {
         },
       });
       if (query.showAddProject) {
+        (window as any).dataLayer?.push({ event: 'github_signup' });
         push(ROUTES.SIGNIN_ONBOARDING);
       } else push(ROUTES.HOME);
     }

diff --git a/apps/web/pages/auth/signup.tsx b/apps/web/pages/auth/signup.tsx
@@ -46,7 +46,7 @@ export default function SignupPage({}) {
           />
           <Input register={register('email')} size="md" placeholder="Email" required error={errors.email?.message} />
           <PasswordInput register={register('password')} size="md" placeholder="Password" required />
-          <Button loading={isSignupLoading} fullWidth type="submit" size="md">
+          <Button id="signup" loading={isSignupLoading} fullWidth type="submit" size="md">
             Create an account
           </Button>
           <Text size="md" align="center">