fix: Prevented duplicate select values to go into AJV Schema (#393)

implerhq · Oct 13, 2023 · 7a3bcb6 · 7a3bcb6
2 parents 0942663 + 2de1ad4
commit 7a3bcb6
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/apps/api/src/app/review/usecases/do-review/do-review.usecase.ts b/apps/api/src/app/review/usecases/do-review/do-review.usecase.ts
@@ -182,13 +182,14 @@ export class DoReview {
         };
         break;
       case ColumnTypesEnum.SELECT:
+        const selectValues =
+          Array.isArray(column.selectValues) && column.selectValues.length > 0
+            ? [...column.selectValues, ...(column.isRequired ? [] : [''])]
+            : [];
         property = {
           type: 'string',
+          enum: Array.from(new Set(selectValues)), // handle duplicate
           ...(!column.isRequired && { default: '' }),
-          ...(Array.isArray(column.selectValues) &&
-            column.selectValues.length > 0 && {
-              enum: [...column.selectValues, ...(column.isRequired ? [] : [''])],
-            }),
         };
         break;
       case ColumnTypesEnum.REGEX: