Default-rule implemented with parsers.all #2491
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatsage-raphael
changed the title
|
Ideally this would have updated the default-rule branch instead of main; I'll keep this in sync with #2482. Please try to leave both branches undeleted and both PRs open. |
ljharb
requested changes
Jul 7, 2022
tests/src/rules/default.js
Outdated
| code: `import foobar from "./typescript"`, | ||
| parser, | ||
|
|
There was a problem hiding this comment.
Suggested change
| features: ['ts'], |
and same for all the TS cases
Comment on lines
-300
to
-302
| parserOptions: { | ||
| tsconfigRootDir: path.resolve(__dirname, '../../files/typescript-no-compiler-options/'), | ||
| }, |
There was a problem hiding this comment.
Just that one or should it be all the parserOptions should be re-added
There was a problem hiding this comment.
We should be keeping any parserOptions that are specific to the test case and can't be generically inferred from features
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb
force-pushed
the
parsers
branch
3 times, most recently
from
11b90b1
to
e96dbc1
Compare
ljharb
force-pushed
the
parsers
branch
2 times, most recently
from
e81ddfd
to
dd74311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2482.