fix: make the timings recorded in wait_duration and histogram consistent #101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #99, there was a comment from me that wasn't addressed: #99 (comment).
We were computing the time spent waiting for a connection twice, once to add it to
internals.wait_duration
and once to record it in a histogram, so the latter is technically always larger. If the process is preempted by the kernel between these points, the timings can diverge significantly, especially in resource-constrained environments when running many threads/processes.This PR changes the
DurationHistogramGuard::elapsed
method into a method that consumesself
and records the elapsed time and returns in lockstep, only invokingInstant::elapsed
once. The destructor that updates the histogram still exists to make the API misuse-resistant and because that's the contract of a guard, but it's not a code path that happens to be taken anywhere in practice right now.