fix(util): Explicitly check for undefined value in getHeaderValues #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for improbable-eng/grpc-web#1109
getHeaderValues does a truthy check with the value that is returned by headers.get
If getValue is an empty string, it fails this check. The empty string is returned by the function and the logic throws an error when .forEach is done on it. Fix is to correctly verify for non existence of the value and return an empty array in that case
Changes
Updated getHeaderValue to first check for the existence using headers.has. If the value does not exist, return empty array. Removed the truthy check afterwords
Verification
Tested by creating a build, using that build in @improbable/grpc-web client and further using that. The issue improbable-eng/grpc-web#1109 goes away