feat: Add database migrations #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kairoaraujo
force-pushed
the
add_db_migrations
branch
2 times, most recently
from
1f3d5eb
to
26a37a6
Compare
This commit implements the database migrations. The database migrations bring more consistency to the user on the deployment as Archivista will handle changes on the SQL Schema. The implementation uses the Versioned Migrations (https://entgo.io/docs/versioned-migrations/). The main reason is that the ent Offline Mode (https://entgo.io/docs/migrate#offline-mode), which seems safer, is migrating to Versioned Migrations. The proposal strategy is to run the migrations during the container start and fail early in case of issues before the archivista application is done in the entry point. During the development, the developers can generate a new migration using the `make db-migrations` if there are changes in the schema files. This commit also implements an automatic check to avoid it for code review. It was added to checks (`db-migrations.yml`) Signed-off-by: Kairo de Araujo <kairo.araujo@testifysec.com>
kairoaraujo
force-pushed
the
add_db_migrations
branch
from
26a37a6
to
7073418
Compare
mikhailswift
approved these changes
Dec 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the database migrations.
The database migrations bring more consistency to the user on the deployment as Archivista will handle changes on the SQL Schema.
The implementation uses the Versioned Migrations.
The main reason is that the ent Offline Mode, which seems safer, is migrating to Versioned Migrations.
The proposal strategy is to run the migrations during the container start and fail early in case of issues before the archivista application is done in the entry point.
During the development, the developers can generate a new migration using the
make db-migrationsif there are changes in the schema files.This commit also implements an automatic check to avoid it for code review. It was added to checks (
db-migrations.yml)