Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added updated check for docs in Makefile #291

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

DarikshaAnsari
Copy link

Fixes #180

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

@DarikshaAnsari
Copy link
Author

@kairoaraujo PTAL !!

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.64%. Comparing base (a035c62) to head (fc49115).
Report is 112 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #291       +/-   ##
==========================================
- Coverage   82.40%   1.64%   -80.76%     
==========================================
  Files          10     120      +110     
  Lines         358   28856    +28498     
==========================================
+ Hits          295     476      +181     
- Misses         43   28323    +28280     
- Partials       20      57       +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kairoaraujo kairoaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DarikshaAnsari,

Thank you for your PR. 🎉
I think we should run the update_docs and the check_docs.

Note: stat -c is not a standard in all OS. Maybe we could check it using diff? 🤔

Nit: I suggest also having it to the .github/workflows for automatic checks. We can do it in another PR as well.

@DarikshaAnsari
Copy link
Author

@kairoaraujo I have changed all the require changes you've mentioned also I have added checks in .github/workflow .

@DarikshaAnsari
Copy link
Author

@kairoaraujo PTAL !!

Signed-off-by: Dariksha <img_2021021@iiitm.ac.in>
Signed-off-by: Dariksha <img_2021021@iiitm.ac.in>
Signed-off-by: Dariksha <img_2021021@iiitm.ac.in>
Signed-off-by: Dariksha <img_2021021@iiitm.ac.in>
.github/workflows/ci.yml Outdated Show resolved Hide resolved
jkjell and others added 2 commits June 6, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: Add a check if the Swagger documentation is updated
3 participants