Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBOM and Omnitrail Attestor #464

Merged
merged 5 commits into from
Jun 13, 2024
Merged

SBOM and Omnitrail Attestor #464

merged 5 commits into from
Jun 13, 2024

Conversation

jkjell
Copy link
Member

@jkjell jkjell commented Jun 10, 2024

Add new go-witness SBOM attestor.

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

…pdate to git attestor

Signed-off-by: John Kjell <john@testifysec.com>
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for witness-project ready!

Name Link
🔨 Latest commit 55d15ab
🔍 Latest deploy log https://app.netlify.com/sites/witness-project/deploys/666b53892c8d96000815949e
😎 Deploy Preview https://deploy-preview-464--witness-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: John Kjell <john@testifysec.com>
@@ -0,0 +1,148 @@
## Schema
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have docs for this new attestor. @fkautz maybe you have a couple mins to add this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #465 to not block this PR.

@@ -133,7 +133,6 @@ func runRun(ctx context.Context, ro options.RunOptions, args []string, signers .
witness.RunWithAttestors(attestors),
witness.RunWithAttestationOpts(attestation.WithWorkingDir(ro.WorkingDir), attestation.WithHashes(roHashes)),
witness.RunWithTimestampers(timestampers...),
witness.RunWithSigners(signers...),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, we were calling this twice?

…cing support)

Signed-off-by: John Kjell <john@testifysec.com>
@jkjell jkjell changed the title SBOM Attestor SBOM and Omnitrail Attestor Jun 13, 2024
Signed-off-by: John Kjell <john@testifysec.com>
Signed-off-by: John Kjell <john@testifysec.com>
Copy link
Collaborator

@ChaosInTheCRD ChaosInTheCRD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jkjell jkjell merged commit c1352bd into main Jun 13, 2024
17 checks passed
@jkjell jkjell deleted the feat/sbom-attestor branch June 13, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants