Bugfix: Skip boolean values in blacklist string check #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes sure to use correct type.
einpraegsam
force-pushed
the
develop
branch
4 times, most recently
from
a31ca4e to
43b5957
Compare
mschwemer
added a commit
that referenced
this pull request
Sep 25, 2024
Thx to @christophlehmann for the PR Related: #646
|
Need to adapt it a little bit and opened a new PR for that. Mentioned you and this PR in the commit message. Thanks. |
mschwemer
added a commit
that referenced
this pull request
Sep 25, 2024
Thx to @christophlehmann for the PR Related: #646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Exception
Argument 1 passed to In2code\Powermail\Domain\Validator\SpamShield\ValueBlacklistMethod::isStringInString() must be of the type string, bool given