[FEATURE] Make it possible to assign variables to the view #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a slot is nice but currently there is no way to assign items to the view besides using xclass. E.g. https://github.com/thomasrawiel/powermailcaptcha/blob/develop/Classes/Controller/FormController.php as example - `setSettings` can't be used because the settings are assigned to the view way earlier - changing the slot is not an option because breaking
georgringer
added a commit
to georgringer/powermailcaptcha
that referenced
this pull request
Jun 2, 2023
Instead of using XCLASS, a slot of powermail can be used Be aware: this requires currently in2code-de/powermail#884 Resolves: thomasrawiel#8
|
Closing it, since there are no signals any more. If you think, there is still the need for the event based code, I would be happy, if you provide a PR for that. Best regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a slot is nice but currently there is no way to assign items to the view besides using xclass. E.g. https://github.com/thomasrawiel/powermailcaptcha/blob/develop/Classes/Controller/FormController.php as example
setSettingscan't be used because the settings are assigned to the view way earlier