SpamNotifyMail doesn't handle answer array values #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I needed to change the base branch as May I ask you to elaborate on the statement: Additionally, it would be cool, if you rebase it to the current master. Thanks for your contribution. |
For example the PowermailAll Mail Partial: |
|
Seems this was fixed in the non-public early access branches via 36eb438 and is already available in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SpamNotificationMail either shows "Array" instead of selected values or dies with an exception for an invalid Array to String typecast.
Easily fixed by using the exact same approach as all other templates do.
fixes #851