Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 #6

Open
wants to merge 8 commits into
base: python3
Choose a base branch
from
Open

Python3 #6

wants to merge 8 commits into from

Conversation

zhskyy
Copy link

@zhskyy zhskyy commented May 17, 2020

  • codebase refactored for python3 support
  • fixed bug with headers update
  • fixed bug with empty body

Tested with python 3.8

Vitaliy Zhaborovskyy added 3 commits October 23, 2019 13:45
…nssl lib api. After this fix proxy works correct in any platform with python and pyopenssl lib without any additional fixes. 2. subjectAltName ssl extension support added. this fixed ERR_CERT_COMMON_NAME_INVALID error
…FError: EOF occurred in violation of protocol
@NoahCardoza
Copy link

NoahCardoza commented Sep 1, 2020

image

Doesn't seem to be properly saving the certs :/

Also NameError: name 'StandardError' is not defined

…ionary and old values has to be deleted for its value update. The "BrokenPipeError" catches at handle_error function. In Python3 it is standalone exception
@zhskyy
Copy link
Author

zhskyy commented Sep 4, 2020

Updated.
checked with python3.7 at Windows 10 and python3.8 and macOS 10.15.6

@NoahCardoza
Copy link

Cool cool! I ended up converting it myself, but this will definitely save other people time.

Thanks

@zhskyy
Copy link
Author

zhskyy commented Sep 10, 2020

Sometimes it rises BrokenPipeError in do_GET function at one of the self.wfile.write call.
This error catches and ignores in handle_error function but I don't sure about the correct proxy work whit this error.

The python 2 version also rises this error, so it doesn't depends on python version.

I will try to reproduce this error in the other proxy and to understand its reason.

In any case, BE CAREFUL WITH this product, it may incorrectly process some requests.

How to reproduce BrokenPipeError error. Run this proxy and configure Chrome to use it.
I used macOS 10.15 and Chrome 85.
Just type something into url filed but NOT press the Enter button. Chrome requests search suggestion and in most cases, this request produces BrokenPipeError error.

@NoahCardoza
Copy link

I'm pretty sure I solved all those errors, I've got it running quite smoothly right now. But it's heavily modded. I might try to refactor it and publish it in the near future. Right now I've worked it into a server that supports http/https/websockets and intercept proxying.

@malikshi
Copy link

any updates ?

@NoahCardoza
Copy link

@malikshi I totally forgot I worked on this but I might be able to dig it up and at least post some of it. Might not be very clean though. I think I'll upload it to my own account if I do though since it seems the GitHub account this repo is on won't be merging my PR any time soon.

@malikshi
Copy link

@malikshi I totally forgot I worked on this but I might be able to dig it up and at least post some of it. Might not be very clean though. I think I'll upload it to my own account if I do though since it seems the GitHub account this repo is on won't be merging my PR any time soon.

Thanks you, That's would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants