Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4 new function download media #6

Merged
merged 47 commits into from
May 28, 2024
Merged

4 new function download media #6

merged 47 commits into from
May 28, 2024

Conversation

SanderDevisscher
Copy link
Collaborator

@SanderDevisscher SanderDevisscher commented Apr 26, 2024 •
edited
Loading

fixes #4
fixes #21
fixes #19

Om te testen:

devtools::install_github("inbo/fistools@4-new-function-download_media")

fistools::download_media()

@SanderDevisscher
Copy download_media.R from fis-projecten
835e523 
#4

https://github.com/inbo/fis-projecten/blob/master/Functions/download_media.R

@LynnPallemaerts FYI
@SanderDevisscher
make a proper function
67366db 
#4
@SanderDevisscher
Update download_media.R
4bd9232 
#4
@SanderDevisscher
Create download_media.Rd
7b25947 
#4
@SanderDevisscher
fix small issue with help
b4257b4 
#4
@SanderDevisscher
add imports
ff34fc1 
#4
@SanderDevisscher
Update download_media.Rd
7d11298 
#4
@SanderDevisscher
Update NAMESPACE
63b0a17 
#4
@SanderDevisscher
Update download_media.R
9023da5 
#4
@SanderDevisscher
Delete scafold.txt
9b98724 
#4
@SanderDevisscher
Create print_hello_world.R
91ea0ad 
#4 hold up the scafold
@SanderDevisscher
add magrittr
613bf82 
#4
@SanderDevisscher
delete src folder
9d9ada0 
blijft errors geven. dient de src folder toch voor iets anders.
@SanderDevisscher
Update DESCRIPTION
f70233e 
#4
@SanderDevisscher
add don't run
0f4f42a 
#4
@SanderDevisscher
Update download_media.R
1973253 
#4
@SanderDevisscher
Delete scafold.txt
37babd6 
#4
@SanderDevisscher
clean up
62415e9 
#4
@SanderDevisscher SanderDevisscher linked an issue Apr 26, 2024 that may be closed by this pull request
[NEW-FUNCTION] download_media #4
Closed
11 tasks
@LynnPallemaerts
Copy link
Contributor

@SanderDevisscher Wil wel reviewen, maar hierboven staat "All checks have failed". Maakt dat uit voor de review?

@SanderDevisscher
Copy link
Collaborator Author

Ok ze falen nu op de scafolding

@SanderDevisscher SanderDevisscher self-assigned this Apr 30, 2024
@SanderDevisscher SanderDevisscher added Function Issue related to a function New Nieuwe functie/data labels Apr 30, 2024
This was linked to issues May 14, 2024
[NEW function] download_favorites #19
Closed
[NEW dataset] Voorbeeld dataset agouti export #21
Closed
SanderDevisscher
SanderDevisscher commented May 14, 2024
View reviewed changes
R/download_media.R Outdated Show resolved Hide resolved
R/download_media.R Outdated Show resolved Hide resolved
R/download_media.R Outdated Show resolved Hide resolved
LynnPallemaerts and others added 14 commits May 27, 2024 13:42
@LynnPallemaerts
preprocess drg agouti export
253b972 
#21
@LynnPallemaerts
Create drg_example.Rda
52ae09c 
#21
@LynnPallemaerts
Roxygenise
9712906 
#21
@LynnPallemaerts
Compress rda file
5a9f9ec 
#21
@LynnPallemaerts
set LazyDataCompression to true
488b25b 
#21
@LynnPallemaerts
fix LazyDataCompression
7a5ef3c 
#21
@LynnPallemaerts
Update .Rbuildignore
c413bb7 
#21
@LynnPallemaerts
Update DESCRIPTION
f1174b4 
Co-Authored-By: soriadelva <158742062+soriadelva@users.noreply.github.com>
Co-Authored-By: Sander Devisscher <sander.devisscher@inbo.be>

#19
@LynnPallemaerts
Rename and split download_media
69d73f3 
Co-Authored-By: soriadelva <158742062+soriadelva@users.noreply.github.com>
Co-Authored-By: Sander Devisscher <sander.devisscher@inbo.be>

#19
@LynnPallemaerts
rerun check
1624a69 
#19
@LynnPallemaerts
update author list
0b4aa12 
Co-Authored-By: soriadelva <158742062+soriadelva@users.noreply.github.com>
Co-Authored-By: Sander Devisscher <sander.devisscher@inbo.be>

#19
@SanderDevisscher
Merge branch 'main' into 4-new-function-download_media
1b78a54
@LynnPallemaerts
add middle names
afa1069 
#19
@LynnPallemaerts
checks
c1972fa 
Co-Authored-By: soriadelva <158742062+soriadelva@users.noreply.github.com>
Co-Authored-By: Sander Devisscher <sander.devisscher@inbo.be>

#19
@SanderDevisscher
Copy link
Collaborator Author

De authors need more indentation I think 😅

@LynnPallemaerts
Copy link
Contributor

De authors need more indentation I think 😅

Why is this even an issue ? 😅

@SanderDevisscher
Copy link
Collaborator Author

De authors need more indentation I think 😅

Why is this even an issue ? 😅

Some coding languages rely on indentation rather than (, { or [ while other use ( for everything (looking at you lisp)

image

@SanderDevisscher SanderDevisscher marked this pull request as ready for review May 27, 2024 15:30
@SanderDevisscher SanderDevisscher merged commit 72921b3 into main May 28, 2024
6 checks passed
@SanderDevisscher SanderDevisscher deleted the 4-new-function-download_media branch May 28, 2024 07:50
@soriadelva soriadelva restored the 4-new-function-download_media branch July 5, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soriadelva soriadelva soriadelva approved these changes

@EmmaCartuyvels1 EmmaCartuyvels1 Awaiting requested review from EmmaCartuyvels1

@LynnPallemaerts LynnPallemaerts Awaiting requested review from LynnPallemaerts

Assignees

@SanderDevisscher SanderDevisscher

Labels
Function Issue related to a function New Nieuwe functie/data
Projects
None yet
Milestone
No milestone
3 participants
@SanderDevisscher @LynnPallemaerts @soriadelva