Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7 new function colcompare #9

Merged
merged 11 commits into from
Apr 30, 2024
Merged

7 new function colcompare #9

merged 11 commits into from
Apr 30, 2024

Conversation

SanderDevisscher
Copy link
Collaborator

@SanderDevisscher SanderDevisscher commented Apr 30, 2024 •
edited
Loading

Fixes #7
Een functie om colnames van 2 dataframes met elkaar te vergelijken + een ondersteuningsfunctie om te bepalen of een environment object bestaat.

@SanderDevisscher SanderDevisscher linked an issue Apr 30, 2024 that may be closed by this pull request
[NEW-FUNCTION] colcompare #7
Closed
11 tasks
@SanderDevisscher SanderDevisscher self-assigned this Apr 30, 2024
@SanderDevisscher SanderDevisscher added Function Issue related to a function New Nieuwe functie/data labels Apr 30, 2024
soriadelva
soriadelva reviewed Apr 30, 2024
View reviewed changes
R/check.R
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I do check(t) it still returns 1, even though I don't have t in my environment, is this correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not correct no

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik blijf dat probleem precies hebben 😕

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ook met een aantal andere random dingen bvb check(de), check(longley), check(t) die yielden allemaal 1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heb je branch terug binnengehaald ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja ,fetched en pulled, heb jij dat probleem niet?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed now

soriadelva
soriadelva requested changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@soriadelva soriadelva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is an issue but see the remark on the check function.
Also there were a few typos in the .Rd files but I wasn't sure if I should fix them bc it states that we shouldn't adjust them manually, otherwise it looks good! 👍

soriadelva and others added 3 commits April 30, 2024 11:37
@soriadelva
Update check.R
fd41321
@SanderDevisscher
fix check
16c6325 
#7

I forgot to invert test 😜
@SanderDevisscher
Update check.Rd
66e601f 
#7

@soriadelva running devtools::check() updates the relevant .rd files
@codecov Codecov
Copy link

codecov bot commented Apr 30, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@SanderDevisscher SanderDevisscher merged commit e855491 into main Apr 30, 2024
6 checks passed
@SanderDevisscher SanderDevisscher deleted the 7-new-function-colcompare branch April 30, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soriadelva soriadelva soriadelva approved these changes

Assignees

@SanderDevisscher SanderDevisscher

Labels
Function Issue related to a function New Nieuwe functie/data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NEW-FUNCTION] colcompare
2 participants
@SanderDevisscher @soriadelva