Docker update #114
Merged
Docker update #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElsLommelen
reviewed
May 31, 2024
REVIEWING.md
Outdated
Comment on lines
8
to
10
| 1. If you have cloned the protocolsource repo, checkout the branch you need to review and use `protocolhelper::render_protocol("<enter the protocolcode here>")` to render the protocol | ||
| 2. Alternatively, ask the author of the protocol to do this for you. The author can then upload a zip-archive of the rendered protocol to the conversation pane of the pull request. | ||
| ``` |
There was a problem hiding this comment.
Kleine suggestie: misschien moet je (evt. mondeling aan de protocolschrijvers) ook even de suggestie geven om het via drive ofzo even door te geven? Afhankelijk van wie de protocolschrijver en reviewer zijn, kan de hier beschreven procedure toch al een hele stap zijn (ervaring met html verdeeld over meerdere bestanden, zippen,...). Anderzijds is het niet minder complex dan dat eerdere artefact, dus voor je geschreven tekst en de meeste gebruikers volstaat dit wel, denk ik.
ElsLommelen
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.