Skip to content

Spp-117-nl #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Aug 30, 2024
Merged

Spp-117-nl #120

merged 26 commits into from
Aug 30, 2024

Conversation

Florian9041
Copy link
Contributor

@Florian9041 Florian9041 commented Jun 13, 2024

Description

spp-117-nl klaar voor review
Hier is gerenderde pdf spp_117_nl_abiotiek_waterlopen.pdf

Related Issue

Task list

Steps by contributor:

  • Add description to this pull request (under "## Description")
  • Open the dropdown (triangle) near 'create pull request' and choose 'Create draft pull request'
  • Check for potential problems by running protocolhelper::check_frontmatter() and address them
  • Check for potential problems by running protocolhelper::check_structure() and address them
  • Add further commits if needed and push them to GitHub
  • Update the protocol-specific NEWS.Rmd
  • Mark the pull request as 'ready for review'

Review steps for the author(s):

  • Add reviewers, at least one subject-matter specialist and one administrator
  • Wait for review comments and address them
  • Iterate until reviewer approvals (merging the pull request will be done by an administrator)
  • Verify that the checks done by continuous integration succeeded. These will check if protocolhelper::check_frontmatter() and protocolhelper::check_structure() succeeded without errors.

To be done by an administrator after review: see guidelines for admins.

Copy link

@anleyssen anleyssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er goed uit; nog enkele zaken aanpassen aub.

@hansvancalster
Copy link
Collaborator

@karenwuyts hier is nog een protocol van het MNM project. De gerenderde versie:
spp_117_nl_abiotiek_waterlopen.zip

Het is klaar om gereviewed te worden.

Copy link

@karenwuyts karenwuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggested changes in 02, 04, 05 and 06. In addition, the title could be more in analogy with spp-116-nl: ‘Abiotische staalname in stromende oppervlaktewateren’; given that this is a project-specific protocol, should the project name be mentioned in the title?

@Florian9041
Copy link
Contributor Author

Small suggested changes in 02, 04, 05 and 06. In addition, the title could be more in analogy with spp-116-nl: ‘Abiotische staalname in stromende oppervlaktewateren’; given that this is a project-specific protocol, should the project name be mentioned in the title?

@anleyssen Wat denk jij?

@anleyssen
Copy link

Ik heb de opmerkingen van Karen bekeken en per item antwoorden gegeven of suggesties voorgesteld. De voorgestelde tekstuele aanpassingen van Karen lijken me allemaal ok.

Copy link
Contributor Author

@Florian9041 Florian9041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alles zou nu in orde moeten zijn

@hansvancalster hansvancalster merged commit e827e15 into main Aug 30, 2024
4 checks passed
@hansvancalster hansvancalster deleted the spp-117-nl branch August 30, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants