Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

estimate densities from point patterns #27

Open
wants to merge 813 commits into
base: master
Choose a base branch
from
Open

estimate densities from point patterns #27

wants to merge 813 commits into from

Conversation

ThierryO
Copy link
Contributor

@stijnvanhoey can you render this? I can't render the SQL tutorial.

@florisvdh
Copy link
Member

Some work to get this tutorial in the right directory structure has been done in the density_fv branch. Fixing CRS specification will folllow later.

Copy link
Member

@florisvdh florisvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThierryO In PR #195 I suggest some changes to get in line with the current tutorials (folder setup, CRS).

Please note:

  • index.md is still to be regenerated - reason: see next point. YAML header in Rmd has been updated already in 'estimate densities from point patterns': PROJ>=6 compliance #195 .
  • the ggmap code with google map will need to be revised. Current code cannot be run (hence, index.md cannot be updated) except when getting a personal API from google and handing your credit card details (and it's free just for a limited period). Not fit for a tutorial anymore IMHO. Maybe you will now rather prefer using OSM.

@florisvdh
Copy link
Member

@ThierryO In PR #195 I suggest some changes to get in line with the current tutorials (folder setup, CRS).

Please note:

  • index.md is still to be regenerated - reason: see next point. YAML header in Rmd has been updated already in 'estimate densities from point patterns': PROJ>=6 compliance #195 .

  • the ggmap code with google map will need to be revised. Current code cannot be run (hence, index.md cannot be updated) except when getting a personal API from google and handing your credit card details (and it's free just for a limited period). Not fit for a tutorial anymore IMHO. Maybe you will now rather prefer using OSM.

Follow-up: PR #195 has now been merged into this PR. @ThierryO the above notes still need some work before it can be merged in master and this long-standing but nice tutorial will be merged.

@ThierryO
Copy link
Contributor Author

Sorry. This has very low priority to me. Feel free to update the code.

@florisvdh
Copy link
Member

@inbo/bmk

florisvdh and others added 22 commits May 4, 2022 16:48

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Update PR template

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Floris Vanderhaeghe <floris.vanderhaeghe@inbo.be>
- 2FA = about GitHub authentication

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
bugfix in RProfile.site
falkmielke and others added 29 commits November 26, 2024 11:45

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Switch to using artifacts v4

Verified

This commit was signed with the committer’s verified signature.
florisvdh Floris Vanderhaeghe

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
r_database_access: update argument of dbConnect()

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
BRMS tutorial: add `rstan` example

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
fix url

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
While reviewing #356, the instructions of the PR template for reviewing seem to no longer work to render the site from the GHA artifact.

With these changes, it seems to work again though, using python -m http.server 8887
Latijns -> italics; https://nl.wikipedia.org/wiki/Cf.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Update pull_request_template.md
The use of 'proj4string' in R code is confusing in times where PROJ.4 strings are obsoleted.
It can be expected that a more general function name to set an object's CRS will sooner or later
be promoted instead of proj4string<-, hence preparing for that already by using the function instead of the slot.
I expect the proj4string slot will most probably remain in use for compatibility reasons, but
explicitly naming it is better avoided in times where WKT2 strings are actually used to define a CRS.
@falkmielke
Copy link
Contributor

Sorry for necro-bumping...
I rebased this branch and added an updated little tutorial to calculate point density.

Feel free to add/comment/wrap up and merge @ThierryO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet