Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updated to latest available sdk #103

Merged
merged 1 commit into from
Sep 24, 2024
Merged

feat: updated to latest available sdk #103

merged 1 commit into from
Sep 24, 2024

Conversation

demeyerthom
Copy link
Collaborator

@demeyerthom demeyerthom commented Sep 10, 2024 •
edited
Loading

  • Updated sdk to latest (which uses any types we cast to the actual type)

@demeyerthom demeyerthom requested a review from a team as a code owner September 10, 2024 12:18
@demeyerthom demeyerthom linked an issue Sep 10, 2024 that may be closed by this pull request
Adyen Gateways resource creation issue #102
Closed
@jobveldhuis
Copy link

Hi there, @demeyerthom. Thanks for this PR, I love it. I do think the upgrade to the CI you did also broke some actions. Could you take a look at that?

@lobre
Copy link
Contributor

lobre commented Sep 17, 2024

I would also be interested in this update. Do you plan to merge it after the CI is fixed or are there other blockers that we could anticipate?

@nbouchez
Copy link

Hi there,
is there any update on this PR ? we are currently blocked in our implementation by errors while creating adyen_gateways resources. Thank you

@nbouchez
Copy link

I just tested your PR, and i'm recieving 404 errors by commerce Layer

Error: 404 Not Found: <!DOCTYPE html>
│ <html>
│ <head>
│   <title>Error 404</title>
│   <meta name="viewport" content="width=device-width,initial-scale=1">
│   <link href="https://data.commercelayer.app/assets/logos/full-logo/white/commercelayer_full_logo_white.svg"
│     rel="preload" as="image">
│   <link href="https://data.commercelayer.app/assets/fonts/eina01.min.css" rel="preload" as="style">
│   <link href="https://data.commercelayer.app/assets/css/commercelayer.v3.min.css" rel="stylesheet">
│ </head>
│ <body class="bg-white">
│   <div class="py-6" style="background-color: #131313;">
│     <img class="w-52 mx-auto max-w-screen-sm lg:max-w-screen-lg"
│       src="https://data.commercelayer.app/assets/logos/full-logo/white/commercelayer_full_logo_white.svg"
│       alt="Commerce Layer logo">
│   </div>
│   <div class="md:h-screen flex flex-wrap justify-center content-center items-center my-auto">
│     <div class="w-screen flex flex-wrap justify-center content-center items-center">
│       <svg class="w-1/2 md:w-2/5 pt-20 pb-10 md:pb-16 fill-current text-gray-200" version="1.1" id="error"
│         xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
│         viewBox="0 0 800 540" style="enable-background:new 0 0 800 540;" xml:space="preserve">
│         <style type="text/css">
│           .st0 {
│             fill: #E5E5E5;
│           }
│         </style>
│         <g id="_x34_04">
│           <g id="_x34_R">
│             <path class="st0"
│               d="M800,287.3h-34.5v73.5h-67.9v-73.5H529.4v-54.7L688,1h77.5v221.9H800V287.3z M697.1,97.3L611,222.9h86.6V97.3H697.1z" />
│           </g>
│           <g id="_x34_L">
│             <path class="st0"
│               d="M270.6,287.3h-34.5v73.5h-67.9v-73.5H0v-54.7L158.6,1h77.5v221.9h34.5V287.3z M167.7,97.3L81.6,222.9h86.6V97.3H167.7z" />
│           </g>
│           <path id="magnifying-glass" class="st0"
│             d="M548.6,361.6c-3.5-6.9-12.2-9.8-19.2-5.8l-11.4,6.5l-13.8-27.6c35.6-21.4,64.1-55,78.2-97.4C613.6,143,562.4,40.8,468.2,9.5S271.7,29.3,240.4,123.6S260.2,320,354.5,351.4c42.4,14.1,86.4,11.4,124.8-4.3l14.5,28.9l-12.7,7.2c-6.4,3.6-8.8,11.7-5.5,18.3l57.8,115.4c10.3,20.5,35.2,28.8,55.8,18.6c20.5-10.3,28.8-35.3,18.6-55.8L548.6,361.6z M372,298.8c-65.3-21.7-100.7-92.4-79-157.7c21.7-65.3,92.4-100.7,157.7-79s100.7,92.4,79,157.7C508,285,437.2,320.5,372,298.8z" />
│           <path id="question-mark" class="st0"
│             d="M412.3,91c-49.6,0-89.9,40.3-89.9,89.9c0,49.6,40.3,89.9,89.9,89.9c49.6,0,89.9-40.3,89.9-89.9C502.3,131.3,461.9,91,412.3,91z M411.4,236c-8,0-13.5-5.4-13.5-13.4c0-7.8,5.6-13.5,13.5-13.5c7.8,0,13.5,5.7,13.5,13.5C424.9,230.6,419.2,236,411.4,236z M420.9,199.9c0,2.1,0.3,3,0.3,3h-21c0,0-0.3-1.9-0.3-3.3c0-23.6,25.8-27.8,25.8-41.6c0-8-5.4-12.6-13.2-12.6c-8.1,0-13.7,5.4-13.7,13.2c0,3.9,0.9,8,0.9,8h-21.3c0,0-1.1-3.9-1.1-8.9c0-18.2,13.7-31.9,35-31.9c22.7,0,35,13.7,35,31.5C447.3,182.1,420.9,187.2,420.9,199.9z" />
│         </g>
│       </svg>
│     </div>
│     <div class="w-screen flex flex-wrap pb-16 justify-center content-end md:content-center items-end md:items-center">
│       <div class="px-6 md:px-32 lg:px-48 text-center">
│         <h2 class="uppercase text-xl md:text-4xl lg:text-5xl leading-tight"
│           style="font-family: Eina01-Bold, sans-serif; color: #131313; font-weight: bold;">Oops, <span
│             style="color: #2DAEFF;">page not found.</span></h2>
│         <p class="mt-2 text-sm md:text-base lg:text-lg max-w-xl md:max-w-4xl text-gray-900"
│           style="font-family: Eina01-Regular, sans-serif; color: #464646">The page you are looking for doesn't seem to
│           exist. It might have been removed, had its name changed, or you might has mistyped the address.</p>
│       </div>
│     </div>
│   </div>
│ </body>
│ </html>
│ 
│   with commercelayer_price_list.mycompany_price_list["ES_EMPLOYEE_FACTORY_EUR"],
│   on price_lists.tf line 28, in resource "commercelayer_price_list" "mycompany_price_list":
│   28: resource "commercelayer_price_list" "mycompany_price_list" {

@demeyerthom
Copy link
Collaborator Author

@jobveldhuis @lobre @nbouchez I need to make some fixes, but I will try to carry this one over the finish today

@demeyerthom demeyerthom changed the title feat: updated to latest available sdk, updated dependencies, removed .idea folder feat: updated to latest available sdk Sep 24, 2024
@demeyerthom demeyerthom force-pushed the 102-adyen-gateways-resource-creation-issue branch from c867fa3 to 25db993 Compare September 24, 2024 08:20
@demeyerthom demeyerthom merged commit d681a9c into main Sep 24, 2024
5 checks passed
@demeyerthom demeyerthom deleted the 102-adyen-gateways-resource-creation-issue branch September 24, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuudJanssen LuudJanssen Awaiting requested review from LuudJanssen

@jobveldhuis jobveldhuis Awaiting requested review from jobveldhuis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adyen Gateways resource creation issue
4 participants
@demeyerthom @jobveldhuis @lobre @nbouchez