Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#58 - Recommender only ever trained once #59

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

reckart
Copy link
Member

@reckart reckart commented Mar 12, 2024

What's in the PR

  • Lock should not be bound to the current thread since we use it to synchronize across threads

How to test manually

  • See issue description

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Lock should not be bound to the current thread since we use it to synchronize across threads
@reckart reckart added the 🐛Bug Something isn't working label Mar 12, 2024
@reckart reckart added this to the 0.1.0 milestone Mar 12, 2024
@reckart reckart self-assigned this Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 51.96%. Comparing base (409739b) to head (5fad012).

Files Patch % Lines
ariadne/server.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   52.08%   51.96%   -0.12%     
==========================================
  Files          24       24              
  Lines         887      889       +2     
==========================================
  Hits          462      462              
- Misses        425      427       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reckart reckart merged commit 538ef21 into main Mar 12, 2024
4 of 6 checks passed
@reckart reckart deleted the bugfix/58-Recommender-only-ever-trained-once branch March 12, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant