fix aenv service create and rm update image

[JacksonMei]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @JacksonMei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines aenv service management by deprecating the capability to modify a service's container image post-creation. It also significantly improves the resilience and user experience of the aenv service create command, allowing for more dynamic configuration retrieval from envhub for parameters like storage and port. Additionally, logging for routine operations has been made less verbose.

Highlights

• Removal of Image Update Functionality: The ability to update a service's container image via the aenv service update command and its underlying API has been completely removed across the client, API service, and documentation.
• Enhanced Service Creation Configuration: The aenv service create command now offers more flexible configuration for services, particularly for storage and port settings. The API service can now intelligently retrieve missing parameters from envhub if they are not explicitly provided in the CLI or local config.json, and the CLI will issue a warning instead of aborting if storageSize is missing locally.
• Logging Adjustments: Several logger.info calls related to routine environment function execution and health checks have been downgraded to logger.debug to reduce log verbosity. Health check messages now also include attempt counts for better context.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces two main changes: it removes the ability to update a service's container image via aenv service update, and it enhances aenv service create to fetch missing configuration from envhub.

The removal of the image update functionality is consistently applied across the CLI, API client, API service, and documentation.

The enhancement to service creation is a great improvement, making the CLI more flexible. The implementation correctly falls back to envhub configuration for most parameters. However, I've noticed a logical inconsistency in how the replicas parameter is handled in the API service compared to other parameters like port and storageSize. My review includes a suggestion to align this for consistency.

Overall, the changes are well-structured. Addressing the noted inconsistency will make the new feature more robust and predictable.

[gemini-code-assist]

The logic for setting replicas is inconsistent with other newly added logic for parameters like port and storageSize. The current implementation unconditionally overrides the replicas value from the request and does not fall back to the serviceConfig from envhub as the comment suggests. This differs from how port, storageSize, etc., are handled, which correctly implement the fallback logic.

To ensure consistency, the logic for replicas should be updated to also fall back to serviceConfig if not provided in the request. Note that for this to work as intended, the default assignment if req.Replicas == 0 { req.Replicas = 1 } (around line 89) should be removed to allow the request's replicas to be 0 when not specified, thus triggering the fallback.

Suggested change

	// Override replicas from request, otherwise use envhub config
	backendEnv.DeployConfig["replicas"] = req.Replicas
	// Override replicas from request, otherwise use envhub config
	if req.Replicas > 0 {
	backendEnv.DeployConfig["replicas"] = req.Replicas
	} else if replicas, ok := serviceConfig["replicas"].(float64); ok {
	backendEnv.DeployConfig["replicas"] = int32(replicas)
	}