update helm deploy yamls #62

lanmaoxinqing · 2026-01-29T09:04:37Z

No description provided.

gemini-code-assist · 2026-01-29T09:05:04Z

Summary of Changes

Hello @lanmaoxinqing, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining and updating the Helm deployment configurations for various services within the application. The changes aim to enhance the flexibility and consistency of deployments by standardizing parameter handling, improving how Object Storage Service (OSS) credentials are managed and distributed, and introducing new configuration options for service behavior. These updates streamline the deployment process and ensure more robust and configurable service operations.

Highlights

Helm Chart Standardization: Standardized and improved Helm chart configurations across multiple services including api-service, controller, envhub, and redis.
API Service Enhancements: Introduced a new aliased api-service-k8s dependency and enhanced the api-service deployment with configurable scheduleType and qps parameters.
Controller Configuration Updates: Refactored the controller's leader-elect argument handling and added a SERVICE_DOMAIN_SUFFIX environment variable for better domain management.
Centralized OSS Secret Management: Centralized Object Storage Service (OSS) secret management by renaming the secret, standardizing key names, and ensuring its availability across both the main and sandbox namespaces.
Redis Persistence Adjustment: Adjusted the default persistence size for Redis from 10Gi to 5Gi.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates several Helm deployment YAML files, introducing new features and refactoring existing configurations. My review focuses on improving the maintainability, consistency, and robustness of the Helm templates. I've identified opportunities to simplify template logic using idiomatic Helm functions, reduce code duplication through helpers, and resolve inconsistencies in how values are handled across different subcharts. There are also a couple of high-severity issues related to missing values and inconsistent variable usage that could cause deployment failures.

gemini-code-assist · 2026-01-29T09:06:47Z

deploy/controller/templates/deployment.yaml

            timeoutSeconds: 1
+          env:
+            - name: SERVICE_DOMAIN_SUFFIX
+              value: {{ .Values.serviceDomainSuffix | quote }}


The template uses .Values.serviceDomainSuffix, but this value is not defined in deploy/controller/values.yaml. If this value is not provided during Helm installation, template rendering will fail. It's crucial to provide a default value. The best practice is to add serviceDomainSuffix: "" to your values.yaml. As a defensive measure in the template, you can use the default function to prevent errors.

value: {{ .Values.serviceDomainSuffix | default "" | quote }}

gemini-code-assist · 2026-01-29T09:06:47Z

deploy/envhub/templates/secret.yaml

+kind: Secret
+metadata:
+  name: oss-secret
+  namespace: {{ .Values.global.sandboxNamespace }}


There is an inconsistency in how sandboxNamespace is accessed across subcharts. This chart (envhub) uses a global value (.Values.global.sandboxNamespace), while the controller chart uses a local value (.Values.sandboxNamespace). This can lead to configuration errors and makes the umbrella chart difficult to manage. For shared configuration like this, you should standardize on using a single global value defined in the parent chart's values.yaml and accessed via .Values.global.sandboxNamespace in all subcharts.

gemini-code-assist · 2026-01-29T09:06:47Z

deploy/Chart.yaml

+  - name: api-service
+    version: "0.0.1"
+    repository: "file://./api-service"
+    condition: api-service-k8s.enabled
+    alias: api-service-k8s


Duplicating the api-service dependency introduces a maintenance risk. If the version of the api-service subchart changes, it will need to be updated in two places, which is error-prone. While this is a common Helm pattern for deploying multiple instances of a subchart, it's important to be aware of this potential for inconsistency.

gemini-code-assist · 2026-01-29T09:06:48Z

deploy/api-service/templates/_helpers.tpl

+{{- define "api-service.scheduleType" -}}
+    {{ if .Values.scheduleType }}
+        {{- .Values.scheduleType -}}
+    {{ else }}
+        {{- printf "k8s" .Values.metadata.namespace -}}
+    {{ end }}
+{{ end }}
+
+{{- define "api-service.qps" -}}
+{{- if .Values.qps }}{{ printf "%v" .Values.qps }}{{ else }}{{ "10" }}{{ end }}
+{{- end }}


The logic in these new helper templates can be significantly simplified and made more idiomatic. The api-service.scheduleType helper uses printf incorrectly, and both helpers can be made more concise by using the default function.

{{- define "api-service.scheduleType" -}} {{- .Values.scheduleType | default "k8s" -}} {{ end }} {{- define "api-service.qps" -}} {{- .Values.qps | default "10" -}} {{- end }}

gemini-code-assist · 2026-01-29T09:06:48Z

deploy/controller/templates/deployment.yaml

+            {{- if .Values.leaderElect }}
+            - --leader-elect=true
+            {{- else }}
+            - --leader-elect=false
+            {{- end }}


This if/else block for the --leader-elect flag is a bit verbose. You can achieve the same result more concisely by embedding the value directly into the argument string.

- --leader-elect={{ .Values.leaderElect }}

gemini-code-assist · 2026-01-29T09:06:48Z

deploy/envhub/templates/deployment.yaml

+            {{if .Values.deploy.templateId}}
+            - --template-id={{ .Values.deploy.templateId }}
+            {{end}}
+            {{if .Values.deploy.callbackURL}}
+            - --callback-url={{ .Values.deploy.callbackURL }}
+            {{end}}


There are a couple of improvements to be made here for style and whitespace control. It's a Helm convention to include a space after if (i.e., {{ if ... }}). Additionally, using {{- and -}} helps control newlines, preventing extra blank lines in the rendered YAML when the conditions are false.

{{- if .Values.deploy.templateId }} - --template-id={{ .Values.deploy.templateId }} {{- end }} {{- if .Values.deploy.callbackURL }} - --callback-url={{ .Values.deploy.callbackURL }} {{- end }}

gemini-code-assist · 2026-01-29T09:06:48Z

deploy/envhub/templates/secret.yaml

+# 为 envhub namespace 创建 OSS secret
 apiVersion: v1
 kind: Secret
 metadata:
-  name: envhub-secret
+  name: oss-secret
  namespace: {{ .Values.metadata.namespace }}
 type: Opaque
 data:
-  # base64编码的值
-  ACI_ACCESS: ""
-  ACI_SECRET: ""
-  OSS_ACCESS_KEY_ID: ""
-  OSS_ACCESS_KEY_SECRET: ""
+  # OSS credentials (base64 encoded)
+  {{- if .Values.oss.accessKeyId }}
+  oss-ak: {{ .Values.oss.accessKeyId | b64enc | quote }}
+  {{- else }}
+  oss-ak: ""
+  {{- end }}
+  {{- if .Values.oss.accessKeySecret }}
+  oss-sk: {{ .Values.oss.accessKeySecret | b64enc | quote }}
+  {{- else }}
+  oss-sk: ""
+  {{- end }}
+  {{- if .Values.oss.endpoint }}
+  oss-endpoint: {{ .Values.oss.endpoint | b64enc | quote }}
+  {{- else }}
+  oss-endpoint: ""
+  {{- end }}
+  {{- if .Values.oss.bucket }}
+  oss-bucket: {{ .Values.oss.bucket | b64enc | quote }}
+  {{- else }}
+  oss-bucket: ""
+  {{- end }}
+---
+# 为 aenv-sandbox namespace 创建相同的 OSS secret
+# 用于 service pod 访问 OSS
+apiVersion: v1
+kind: Secret
+metadata:
+  name: oss-secret
+  namespace: {{ .Values.global.sandboxNamespace }}
+type: Opaque
+data:
+  # OSS credentials (base64 encoded)
+  {{- if .Values.oss.accessKeyId }}
+  oss-ak: {{ .Values.oss.accessKeyId | b64enc | quote }}
+  {{- else }}
+  oss-ak: ""
+  {{- end }}
+  {{- if .Values.oss.accessKeySecret }}
+  oss-sk: {{ .Values.oss.accessKeySecret | b64enc | quote }}
+  {{- else }}
+  oss-sk: ""
+  {{- end }}
+  {{- if .Values.oss.endpoint }}
+  oss-endpoint: {{ .Values.oss.endpoint | b64enc | quote }}
+  {{- else }}
+  oss-endpoint: ""
+  {{- end }}
+  {{- if .Values.oss.bucket }}
+  oss-bucket: {{ .Values.oss.bucket | b64enc | quote }}
+  {{- else }}
+  oss-bucket: ""
+  {{- end }}


This file defines the same oss-secret twice, once for each namespace. This leads to significant code duplication and is a maintenance concern. If the secret's structure changes, you'll have to update it in two places.

A better approach is to define a helper template in _helpers.tpl for the secret data and then include it in both secret definitions. This follows the Don't Repeat Yourself (DRY) principle.

For example, in deploy/envhub/templates/_helpers.tpl:

{{- define "envhub.ossSecretData" -}} # OSS credentials (base64 encoded) ... {{- end -}}

And then in secret.yaml:

... data: {{ include "envhub.ossSecretData" . | nindent 2 }} --- ... data: {{ include "envhub.ossSecretData" . | nindent 2 }}

JacksonMei

lgtm

update helm deploy yamls

f217373

lanmaoxinqing requested a review from JacksonMei January 29, 2026 09:04

gemini-code-assist bot reviewed Jan 29, 2026

View reviewed changes

JacksonMei approved these changes Jan 29, 2026

View reviewed changes

JacksonMei merged commit a41ae60 into main Jan 29, 2026
1 check failed

JacksonMei deleted the sky/deploy_config branch January 29, 2026 09:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update helm deploy yamls #62

update helm deploy yamls #62

Uh oh!

lanmaoxinqing commented Jan 29, 2026

Uh oh!

gemini-code-assist bot commented Jan 29, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 29, 2026

Uh oh!

gemini-code-assist bot Jan 29, 2026

Uh oh!

gemini-code-assist bot Jan 29, 2026

Uh oh!

gemini-code-assist bot Jan 29, 2026

Uh oh!

gemini-code-assist bot Jan 29, 2026

Uh oh!

gemini-code-assist bot Jan 29, 2026

Uh oh!

gemini-code-assist bot Jan 29, 2026

Uh oh!

JacksonMei left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

update helm deploy yamls #62

update helm deploy yamls #62

Uh oh!

Conversation

lanmaoxinqing commented Jan 29, 2026

Uh oh!

gemini-code-assist bot commented Jan 29, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

JacksonMei left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants