Skip to content

Conversation

@AIxyz
Copy link

@AIxyz AIxyz commented Jan 12, 2026

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @AIxyz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a new demonstration guide for dinfer_openai serving. The guide outlines the steps to launch the server and provides a practical example of how to send a chat completion request to it using a curl command. This enhancement aims to simplify the process for users to quickly get started with and test the dinfer_openai service.

Highlights

  • New Demo Added: Introduces a new markdown file (demo/serving_dinfer_openai.md) that provides instructions for setting up and interacting with a dinfer_openai serving instance.
  • Serving Instructions: Details how to start the dinfer_openai server using a Python script.
  • Client Interaction Example: Provides a curl command example to send a chat completion request to the running dinfer_openai server, demonstrating how to interact with the service.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for a serving_dinfer_openai demo. However, the Python script serving_dinfer_openai.py referenced in the documentation is missing from the changes, which makes the demo incomplete. Please add the script to this pull request. I've also left a comment regarding a hardcoded API key in the example curl command, which should be replaced with a placeholder for security best practices.

## Client

```bash
date && curl -X POST -H "Content-Type: application/json" -H "Authorization: Bearer 12345678" -N -d '{"messages": [{"role": "user", "content": "你好, 我是小明"}], "stream": false}' http://0.0.0.0:48000/v1/chat/completions && date

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

The curl command includes a hardcoded bearer token (12345678). While this is a demo, it's a bad practice to hardcode credentials, even dummy ones, in documentation. It can lead to security vulnerabilities if this pattern is copied elsewhere. It's better to use a placeholder to indicate that a user should provide their own token.

Suggested change
date && curl -X POST -H "Content-Type: application/json" -H "Authorization: Bearer 12345678" -N -d '{"messages": [{"role": "user", "content": "你好, 我是小明"}], "stream": false}' http://0.0.0.0:48000/v1/chat/completions && date
date && curl -X POST -H "Content-Type: application/json" -H "Authorization: Bearer <YOUR_API_KEY>" -N -d '{"messages": [{"role": "user", "content": "你好, 我是小明"}], "stream": false}' http://0.0.0.0:48000/v1/chat/completions && date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant