fix: resolve contrast issue with header bar (fixes #1739) (#1741)

* fix: resolve contrast issue with header bar (fixes #1739) * ci: add commitlint check
inclusive-design · Mar 11, 2024 · 1499fa8 · 1499fa8
1 parent 49d674e
commit 1499fa8
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 45 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -1,4 +1,4 @@
-name: Lint assets
+name: Run tests
 
 on:
   push:
@@ -9,7 +9,7 @@ on:
     branches:
       - dev
 jobs:
-  lint:
+  test:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
@@ -22,3 +22,6 @@ jobs:
       run: npm ci
     - name: Lint assets
       run: npm run lint
+    - name: Ensure that commitlint works
+      run: |
+        echo "fix: make sure commitlint works" | npx --no-install commitlint
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -61,7 +61,7 @@
   },
   "devDependencies": {
     "@commitlint/cli": "18.6.0",
-    "@commitlint/config-conventional": "19.0.3",
+    "@commitlint/config-conventional": "18.6.3",
     "autoprefixer": "10.4.17",
     "cross-env": "7.0.3",
     "decap-server": "3.0.2",

diff --git a/src/assets/styles/components/_idrc-indicator.scss b/src/assets/styles/components/_idrc-indicator.scss
@@ -17,3 +17,9 @@
 		}
 	}
 }
+
+.idrc-indicator-element a {
+	color: $black;
+	text-decoration: underline;
+	text-underline-offset: calc(2 / 16 * 1rem);
+}