Skip to content

Commit

Permalink
Merge pull request #23 from increments/fix-falling-tests
Browse files Browse the repository at this point in the history
Fix falling tests
  • Loading branch information
kyntk authored Feb 9, 2024
2 parents d31e72f + 36f86c5 commit 4c05c82
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Test

on:
pull_request:
push:
types: [opened, synchronize, reopened, ready_for_review]
workflow_dispatch:
schedule:
- cron: "0 1 * * 1" # At 01:00 (UTC) / 10:00 (JST) on Monday
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@ node_modules
tmp/camouflage.pid
tmp/camo.pid
.node-version

.bundle
.ruby-version
vendor
4 changes: 2 additions & 2 deletions test/proxy_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def test_proxy_survives_redirect_without_location
end
end

response = request('http://media.ebaumsworld.com/picture/Mincemeat/Pimp.jpg')
response = request('https://qiita-image-store.s3.ap-northeast-1.amazonaws.com/0/55950/dee6d393-c8a2-887a-889e-1cf4ebd3896a.png')
assert_equal(200, response.code)
end

Expand Down Expand Up @@ -80,7 +80,7 @@ def test_always_sets_security_headers
end

def test_proxy_valid_image_url
response = request('http://media.ebaumsworld.com/picture/Mincemeat/Pimp.jpg')
response = request('https://qiita-image-store.s3.ap-northeast-1.amazonaws.com/0/55950/dee6d393-c8a2-887a-889e-1cf4ebd3896a.png')
assert_equal(200, response.code)
end

Expand Down

0 comments on commit 4c05c82

Please sign in to comment.