Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node 18 #13

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Support node 18 #13

merged 2 commits into from
Aug 31, 2023

Conversation

tomoasleep
Copy link
Member

@tomoasleep tomoasleep commented Aug 18, 2023

This PR updates node 17 and 18. Besides, update docker base image to use 18.17.1.

operation check

I've tested the docker image in our infra. (https://github.com/increments/camo-ecspresso/issues/4)

@tomoasleep tomoasleep requested review from a team and kyntk and removed request for a team August 29, 2023 11:39
@tomoasleep tomoasleep marked this pull request as ready for review August 29, 2023 11:39
@tomoasleep tomoasleep changed the title Update package-lock.json to support node 18 Support node 18 Aug 30, 2023
@kyntk
Copy link

kyntk commented Aug 31, 2023

Copy link

@kyntk kyntk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomoasleep
Copy link
Member Author

Thank you!

@tomoasleep tomoasleep merged commit 73a0d75 into master Aug 31, 2023
2 checks passed
@tomoasleep tomoasleep deleted the support-node-18 branch August 31, 2023 02:58
This was referenced Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants