Bump node from 18.17.1 to 20.11.0 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyntk
force-pushed
the
docker/node-20.11.0
branch
2 times, most recently
from
b80bf73
to
0cc4d2e
Compare
kyntk
commented
Feb 9, 2024
| @@ -194,7 +194,7 @@ process_url = (url, transferredHeaders, resp, remaining_redirects) -> | |||
| # decode a string of two char hex digits | |||
| hexdec = (str) -> | |||
| if str and str.length > 0 and str.length % 2 == 0 and not str.match(/[^0-9a-f]/) | |||
| buf = new Buffer(str.length / 2) | |||
| buf = new Buffer.alloc(str.length / 2) | |||
There was a problem hiding this comment.
Fixed this error
DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
0cc4d2e
to
f5e6534
Compare
kyntk
requested review from
a team and
atm-snag2
and removed request for
a team
atm-snag2
reviewed
Feb 9, 2024
CHANGELOG.md
Outdated
| @@ -3,6 +3,8 @@ Unreleased | |||
|
|
|||
| <!-- Add descriptions of changes here --> | |||
|
|
|||
| * Add support for Node v20 and drop support for Node v17 [22](https://github.com/increments/camo/pull/22) | |||
There was a problem hiding this comment.
maybe
Suggested change
| * Add support for Node v20 and drop support for Node v17 [22](https://github.com/increments/camo/pull/22) | |
| * Add support for Node v20 and drop support for Node v17 or before [22](https://github.com/increments/camo/pull/22) |
kyntk
force-pushed
the
docker/node-20.11.0
branch
from
f5e6534
to
63eb30f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What