New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nullable scope path creation #23

Open

sdsd08013 wants to merge 2 commits into increments:master from sdsd08013:fix/create_nullable_scope_path

+43 −4

sdsd08013 commented Jan 23, 2019

problem

If passed Optional scope path like (/:locale)/users(.:format) to Route constructor.

Route instance member @path set value "".

because:
route.path.spec.to_s.split('(') => ["", "/:locale)/users", ".:format)"]

change

@path = route.path.spec.to_s.sub(/\(.:format\)/, "").delete('(', '').delete(')', '')

this return right path /:locale)/users

plz check it.

iwsksky added 2 commits

January 23, 2019 17:39


          fix route path

d57d94c


          add testing

64aaa03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet