Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add root option to github action template #54

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

getty104
Copy link
Member

What

How

  • action.ymlでrootを指定できるようになったため、生成するGitHub Actionsのテンプレートにもrootを追加した
    • デフォルト値をaction.ymlで設定しているため、過去のバージョンで生成されたGitHub Actionsを利用していても問題なく動く

Why

Refs

@getty104 getty104 requested review from a team and ohakutsu and removed request for a team August 21, 2023 23:57
@getty104 getty104 self-assigned this Aug 21, 2023
@getty104 getty104 requested review from a team, acronhub and wataru86 and removed request for ohakutsu, a team and acronhub August 22, 2023 02:53
Copy link
Member

@wataru86 wataru86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -30,6 +30,7 @@ jobs:
- uses: increments/qiita-cli/actions/publish@v1
with:
qiita-token: \${{ secrets.QIITA_TOKEN }}
root: "."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[memo]

#51root が追加されている。

inputs:
root:
required: false
default: "."
description: "Root directory path"

@getty104 getty104 merged commit 21cc2f1 into main Aug 22, 2023
5 checks passed
@getty104 getty104 deleted the add-root-option-to-github-action branch August 22, 2023 03:24
@getty104 getty104 mentioned this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants