Skip to content

Commit

Permalink
Require Faraday v2
Browse files Browse the repository at this point in the history
  • Loading branch information
nipe0324 committed Oct 21, 2023
1 parent 54ec806 commit 688bab4
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 5 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
## Unreleased

- Require Faraday v2

## v1.4.0

- Migrate CI/CD platform from Travis CI to GitHub Actions
- Requires Ruby 3.0.0 or higher
- Require Ruby 3.0.0 or higher

## v1.3.5

Expand Down
1 change: 0 additions & 1 deletion lib/qiita.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
require "active_support/core_ext/string/inflections"
require "active_support/core_ext/string/strip"
require "faraday"
require "faraday_middleware"
require "json"
require "rack/utils"
require "rainbow"
Expand Down
5 changes: 2 additions & 3 deletions qiita.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]

spec.add_dependency "activesupport"
spec.add_dependency "faraday", "~> 0.9"
spec.add_dependency "faraday_middleware"
spec.add_dependency 'faraday', '>= 2', '< 3'
spec.add_dependency "rack"
spec.add_dependency "rainbow"
spec.add_dependency "rouge"
Expand All @@ -27,5 +26,5 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "pry"
spec.add_development_dependency "rake"
spec.add_development_dependency "rspec"
spec.add_development_dependency "webmock", "1.20.4"
spec.add_development_dependency "webmock"
end
8 changes: 8 additions & 0 deletions spec/qiita/client_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,10 @@ def stub_api_request
204
end

let(:response_hash) do
nil
end

include_examples "valid condition"
include_examples "sends request with JSON-encoded body"
end
Expand All @@ -362,6 +366,10 @@ def stub_api_request
204
end

let(:response_hash) do
nil
end

include_examples "valid condition"
include_examples "sends request with URL query"
end
Expand Down

0 comments on commit 688bab4

Please sign in to comment.