Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Ruby 3.0.0 or higher #19

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

nipe0324
Copy link
Contributor

@nipe0324 nipe0324 commented Sep 28, 2023

close #17

Ruby 2.7 or lower versions are EOL ( https://www.ruby-lang.org/en/downloads/branches/ ). I tried to require Ruby 3.0.0 or higher.

@nipe0324
Copy link
Contributor Author

nipe0324 commented Oct 2, 2023

@mziyut Would you review this PR?

Copy link
Contributor

@mziyut mziyut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
LGTM 👍

Copy link
Member

@ohakutsu ohakutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ GTM!!

@nipe0324
Copy link
Contributor Author

@mziyut

Thank you for reviews :)
How should I merge this PR?

@ohakutsu
Copy link
Member

Sorry, I will merge now!

@ohakutsu ohakutsu merged commit be06228 into increments:master Oct 13, 2023
1 check passed
@nipe0324 nipe0324 deleted the require-ruby-3.0.0-or-higher branch October 13, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Ruby v3.x
4 participants